Skip to content

Commit 8839d1a

Browse files
committed
AG-50658: skip copying locales files for filters for fast review
1 parent 0340c39 commit 8839d1a

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

tools/resources-mv3.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ import { AssetsFiltersBrowser, DECLARATIVE_FILTERS_DEST } from './constants';
3636
*/
3737
const resourcesMv3 = async (skipLocalResources = false) => {
3838
console.log('Downloading resources for MV3...');
39-
await downloadAndPrepareMv3Filters();
39+
// Skip translations only during fast auto-build (skip review)
40+
// to minimize changes and stay eligible for expedited review.
41+
await downloadAndPrepareMv3Filters(skipLocalResources);
4042
console.log('Resources for MV3 downloaded');
4143

4244
if (!skipLocalResources) {

tools/resources/download-filters.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,13 +187,19 @@ const downloadFilter = async (resourceData: DownloadResourceData, browser: Asset
187187
/**
188188
* Copies the DNR rulesets from the @adguard/dnr-rulesets internal directory to
189189
* the declarative filters directory in browser extension.
190+
*
191+
* @param skipTranslations If true, skips copying translations.
192+
* Should be true only for fast auto-build reviews (skip review)
193+
* to minimize changes and stay eligible for expedited review.
190194
*/
191-
export const downloadAndPrepareMv3Filters = async () => {
195+
export const downloadAndPrepareMv3Filters = async (skipTranslations = false) => {
192196
const loader = new AssetsLoader();
193197

198+
const dest = FILTERS_DEST.replace('%browser', AssetsFiltersBrowser.ChromiumMv3);
199+
194200
// Note: it is just copying the files from the @adguard/dnr-rulesets package
195201
// to the filters directory. The files are already downloaded.
196-
return loader.load(FILTERS_DEST.replace('%browser', AssetsFiltersBrowser.ChromiumMv3));
202+
return loader.load(dest, { skipTranslations });
197203
};
198204

199205
/**

0 commit comments

Comments
 (0)