Lint only updated files stricter linting and update the PR workflow (PalisadoesFoundation#1677)

* Replace package vm2 with isolated-vm (PalisadoesFoundation#1532)

* Replace package vm2 with isolated-vm

* Removed package isolated-vm

* init: lint-staged for linting staged files only

* feat: convert warn to error in eslintrc

* fix: failing tests

* fix: package.json

* fix: package-lock

* chore(deps): bump follow-redirects from 1.15.3 to 1.15.4 (PalisadoesFoundation#1668)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: workflow job runs for changed files in the pushed commit only

* fix: resolve conflict with upstream/develop

* fix:package-lock

* fix: attemp#2 merge conflict

* fix: merge conflict #3

* fix: npm script instead of npx, filter git diff command

* fix: package.json conflict

* fix: remove vite

* resolve merge conflict

* attempt #2 fix conflict

* update package-lock

* update package-lock

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Sarthak Patel <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: 3 people

.eslintrc.json

@@ -57,20 +57,20 @@
     ],
 
     // restrict the use of same package in multiple import statements
-    "import/no-duplicates": "warn",
+    "import/no-duplicates": "error",
 
     // warn/1, error/2, off/0
-    "tsdoc/syntax": "warn",
+    "tsdoc/syntax": "error",
 
     // Typescript Rules
-    "@typescript-eslint/ban-ts-comment": "warn",
-    "@typescript-eslint/no-explicit-any": "warn",
-    "@typescript-eslint/no-inferrable-types": "warn",
-    "@typescript-eslint/no-non-null-asserted-optional-chain": "warn",
-    "@typescript-eslint/no-non-null-assertion": "warn",
-    "@typescript-eslint/no-var-requires": "warn",
-    "@typescript-eslint/ban-types": "warn",
-    "@typescript-eslint/no-duplicate-enum-values": "warn",
+    "@typescript-eslint/ban-ts-comment": "error",
+    "@typescript-eslint/no-explicit-any": "error",
+    "@typescript-eslint/no-inferrable-types": "error",
+    "@typescript-eslint/no-non-null-asserted-optional-chain": "error",
+    "@typescript-eslint/no-non-null-assertion": "error",
+    "@typescript-eslint/no-var-requires": "error",
+    "@typescript-eslint/ban-types": "error",
+    "@typescript-eslint/no-duplicate-enum-values": "error",
 
     // Typescript rule to enforce PascalCase naming convention for types and interfaces
     "@typescript-eslint/naming-convention": [
@@ -115,9 +115,9 @@
     ],
 
     // Typescript additional rules
-    "@typescript-eslint/array-type": "warn",
-    "@typescript-eslint/consistent-type-assertions": "warn",
-    "@typescript-eslint/consistent-type-imports": "warn",
-    "@typescript-eslint/explicit-function-return-type": "warn"
+    "@typescript-eslint/array-type": "error",
+    "@typescript-eslint/consistent-type-assertions": "error",
+    "@typescript-eslint/consistent-type-imports": "error",
+    "@typescript-eslint/explicit-function-return-type": "error"
   }
 }

.github/workflows/pull-request.yml

@@ -49,8 +49,8 @@ jobs:
       - name: Install Dependencies
         run: npm ci
 
-      - name: Run ESLint to check for linting errors
-        run: npm run lint:check
+      - name: Run ESLint to check for linting errors in modified files
+        run: npx eslint $(git diff --name-only --diff-filter=d -- '***.ts' ${{ github.event.before }} ${{ github.sha }})
 
       - name: Check for formatting errors
         run: npm run format:check

.husky/pre-commit

@@ -6,15 +6,13 @@
 # Change to the current directory
 . "$(dirname -- "$0")/_/husky.sh"
 
-# Formats code using prettier.
-npm run format:fix
-
 # Checks code for typescript type errors and throws errors if found.
 npm run typecheck
 
+# Formats code using prettier
 # Checks and fixes all lint issues in code which don't require manual intervention.
 # Throws errors if lint issues requiring manual intervention are found in code.
-npm run lint:fix
+npm run lint-staged
 
 npm run gen:schema