Add database secret validation and better error logging

Author: Alexander-Rees

.github/workflows/data-ingestion.yml

@@ -34,13 +34,29 @@ jobs:
         run: |
           pip install -r requirements.txt
       
+      - name: Verify database secrets
+        run: |
+          if [ -z "${{ secrets.DB_HOST }}" ]; then
+            echo "❌ Error: DB_HOST secret is not set"
+            exit 1
+          fi
+          if [ -z "${{ secrets.DB_PASSWORD }}" ]; then
+            echo "❌ Error: DB_PASSWORD secret is not set"
+            exit 1
+          fi
+          echo "✅ Database secrets are configured"
+          echo "DB_HOST: ${{ secrets.DB_HOST }}"
+          echo "DB_USER: ${{ secrets.DB_USER || 'postgres' }}"
+          echo "DB_NAME: ${{ secrets.DB_NAME || 'postgres' }}"
+          echo "DB_PORT: ${{ secrets.DB_PORT || '5432' }}"
+      
       - name: Run data ingestion
         working-directory: flask-api
         env:
           DB_HOST: ${{ secrets.DB_HOST }}
-          DB_USER: ${{ secrets.DB_USER }}
+          DB_USER: ${{ secrets.DB_USER || 'postgres' }}
           DB_PASSWORD: ${{ secrets.DB_PASSWORD }}
-          DB_NAME: ${{ secrets.DB_NAME || 'fantasy_soccer' }}
+          DB_NAME: ${{ secrets.DB_NAME || 'postgres' }}
           DB_PORT: ${{ secrets.DB_PORT || '5432' }}
           ELO_DATA_PATH: ../temp-elo-data/data
         run: |

flask-api/scripts/ingest_elo_and_fpl.py

@@ -50,11 +50,19 @@
 def get_db_connection():
     """Get PostgreSQL database connection"""
     try:
+        # Log connection details (without password)
+        logger.info(f"Attempting to connect to PostgreSQL: {DB_CONFIG['host']}:{DB_CONFIG['port']}/{DB_CONFIG['database']} as {DB_CONFIG['user']}")
+        
+        if not DB_CONFIG['password']:
+            logger.error("DB_PASSWORD environment variable is not set!")
+            raise ValueError("DB_PASSWORD is required but not set")
+        
         connection = psycopg2.connect(**DB_CONFIG)
         logger.info("Successfully connected to PostgreSQL database")
         return connection
     except Error as e:
         logger.error(f"Error connecting to PostgreSQL: {e}")
+        logger.error(f"Connection config: host={DB_CONFIG['host']}, port={DB_CONFIG['port']}, database={DB_CONFIG['database']}, user={DB_CONFIG['user']}")
         raise
 
 def fetch_fpl_data():