Refactor orchestrator pulse script for better logging

Author: Alexanderk30

scripts/orchestrator-pulse.sh

@@ -1,23 +1,63 @@
 #!/bin/bash
 # QuickClaw Orchestrator Pulse - Triggers orchestrator check-in
+set -euo pipefail
+
+# Require QUICKCLAW_HOME to be set
+if [ -z "${QUICKCLAW_HOME:-}" ]; then
+  echo "ERROR: QUICKCLAW_HOME environment variable is not set" >&2
+  exit 1
+fi
+
+# Require a message argument
+if [ -z "${1:-}" ]; then
+  echo "ERROR: Message argument is required" >&2
+  echo "Usage: $0 <message>" >&2
+  exit 1
+fi
+
+MESSAGE="$1"
+LOG_FILE="$QUICKCLAW_HOME/logs/orchestrator.log"
+OPENCLAW_PORT="${OPENCLAW_PORT:-18789}"
+OPENCLAW_CONFIG="${OPENCLAW_CONFIG:-$HOME/.openclaw/openclaw.json}"
 
-LOG_FILE="/Users/clawd/quickclaw/logs/orchestrator.log"
 mkdir -p "$(dirname "$LOG_FILE")"
 
-echo "[$(date '+%Y-%m-%d %H:%M:%S')] Orchestrator pulse: $1" >> "$LOG_FILE"
+log() {
+  echo "[$(date '+%Y-%m-%d %H:%M:%S')] $1" >> "$LOG_FILE"
+}
+
+log "Orchestrator pulse: $MESSAGE"
+
+# Verify config file exists before attempting to read
+if [ ! -f "$OPENCLAW_CONFIG" ]; then
+  log "ERROR: OpenClaw config not found at $OPENCLAW_CONFIG"
+  exit 1
+fi
 
 # Get the auth token from openclaw.json
-TOKEN=$(grep -o '"token": "[^"]*"' /Users/clawd/.openclaw/openclaw.json 2>/dev/null | head -1 | cut -d'"' -f4)
+TOKEN=$(grep -o '"token": "[^"]*"' "$OPENCLAW_CONFIG" 2>/dev/null | head -1 | cut -d'"' -f4)
 
 if [ -z "$TOKEN" ]; then
-    echo "[$(date '+%Y-%m-%d %H:%M:%S')] ERROR: Could not find auth token" >> "$LOG_FILE"
-    exit 1
+  log "ERROR: Could not find auth token in $OPENCLAW_CONFIG"
+  exit 1
 fi
 
+# Build JSON payload safely using printf to avoid injection
+PAYLOAD=$(printf '{"agentId": "orchestrator", "message": "%s"}' "$MESSAGE")
+
 # Send message to orchestrator
-curl -s -X POST http://localhost:18789/api/v1/sessions \
+HTTP_STATUS=$(curl -s -o /tmp/quickclaw_response.tmp -w "%{http_code}" \
+  -X POST "http://localhost:${OPENCLAW_PORT}/api/v1/sessions" \
   -H "Authorization: Bearer $TOKEN" \
   -H "Content-Type: application/json" \
-  -d "{\"agentId\": \"orchestrator\", \"message\": \"$1\"}" >> "$LOG_FILE" 2>&1
+  -d "$PAYLOAD")
+
+if [ "$HTTP_STATUS" -ge 200 ] && [ "$HTTP_STATUS" -lt 300 ]; then
+  log "Pulse delivered successfully (HTTP $HTTP_STATUS)"
+else
+  log "ERROR: Pulse failed (HTTP $HTTP_STATUS): $(cat /tmp/quickclaw_response.tmp 2>/dev/null)"
+  rm -f /tmp/quickclaw_response.tmp
+  exit 1
+fi
 
-echo "" >> "$LOG_FILE"
+rm -f /tmp/quickclaw_response.tmp