Skip to content

Commit 2f6b6bb

Browse files
committed
Ensure deprecated parse and write features exist, but are unused.
1 parent ef89a67 commit 2f6b6bb

File tree

4 files changed

+41
-10
lines changed

4 files changed

+41
-10
lines changed

ci/test.sh

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,17 @@ check() {
7878
check_test "write-integer"
7979

8080
# ensure our partial features aren't allowed, as are unsupported features
81-
cd "${home}/lexical-core"
82-
partial=(parse write floats integers)
83-
for feature in "${partial[@]}"; do
84-
check_error "${feature}"
85-
done
86-
87-
cd "${home}/lexical"
88-
for feature in "${partial[@]}"; do
89-
check_error "${feature}"
90-
done
81+
# FIXME: Restore once we remove our partial features
82+
# cd "${home}/lexical-core"
83+
# partial=(parse write floats integers)
84+
# for feature in "${partial[@]}"; do
85+
# check_error "${feature}"
86+
# done
87+
#
88+
# cd "${home}/lexical"
89+
# for feature in "${partial[@]}"; do
90+
# check_error "${feature}"
91+
# done
9192

9293
cd "${home}"
9394
}

lexical-core/Cargo.toml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,16 @@ f128 = [
129129
"lexical-write-float?/f128"
130130
]
131131

132+
# DEPRECATED
133+
# ----------
134+
# These were never supported, however, they exist in case existing code
135+
# uses them. They should not be used under any circumstances and should
136+
# be removed.
137+
parse = ["parse-integers", "parse-floats"]
138+
write = ["write-integers", "write-floats"]
139+
integers = ["parse-integers", "write-integers"]
140+
floats = ["parse-floats", "write-floats"]
141+
132142
[package.metadata.docs.rs]
133143
features = ["radix", "format", "write-integers", "write-floats", "parse-integers", "parse-floats", "f16"]
134144
rustdoc-args = ["--cfg", "docsrs"]

lexical-util/Cargo.toml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,16 @@ lint = []
6464
# Enable support for 128-bit floats.
6565
f128 = ["parse-floats", "write-floats"]
6666

67+
# DEPRECATED
68+
# ----------
69+
# These were never supported, however, they exist in case existing code
70+
# uses them. They should not be used under any circumstances and should
71+
# be removed.
72+
parse = ["parse-integers", "parse-floats"]
73+
write = ["write-integers", "write-floats"]
74+
integers = ["parse-integers", "write-integers"]
75+
floats = ["parse-floats", "write-floats"]
76+
6777
[package.metadata.docs.rs]
6878
features = ["radix", "format", "write-integers", "write-floats", "parse-integers", "parse-floats", "f16"]
6979
rustdoc-args = ["--cfg", "docsrs"]

lexical/Cargo.toml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,16 @@ lint = ["lexical-core/lint"]
6060
# https://github.com/Alexhuszagh/rust-lexical/issues/46
6161
f128 = ["lexical-core/f128"]
6262

63+
# DEPRECATED
64+
# ----------
65+
# These were never supported, however, they exist in case existing code
66+
# uses them. They should not be used under any circumstances and should
67+
# be removed.
68+
parse = ["parse-integers", "parse-floats"]
69+
write = ["write-integers", "write-floats"]
70+
integers = ["parse-integers", "write-integers"]
71+
floats = ["parse-floats", "write-floats"]
72+
6373
[package.metadata.docs.rs]
6474
features = ["radix", "format", "write-integers", "write-floats", "parse-integers", "parse-floats", "f16"]
6575
rustdoc-args = ["--cfg", "docsrs"]

0 commit comments

Comments
 (0)