Fix/links context bug (#292)

* fix bug where context not set in links endpoints

Author: Ryo Chijiiwa

dynamic_rest/fields/fields.py

@@ -251,13 +251,13 @@ def get_serializer(self, *args, **kwargs):
         if self.embed and self._is_dynamic:
             init_args['embed'] = True
 
-        return self._get_cached_serializer(args, init_args)
+        serializer = self._get_cached_serializer(args, init_args)
+        serializer.parent = self
+        return serializer
 
     @resettable_cached_property
     def serializer(self):
-        serializer = self.get_serializer()
-        serializer.parent = self
-        return serializer
+        return self.get_serializer()
 
     @cached_property
     def _is_dynamic(self):

dynamic_rest/viewsets.py

@@ -391,20 +391,22 @@ def list_related(self, request, pk=None, field_name=None):
             return Response("Not found", status=404)
 
         # Serialize the related data. Use the field's serializer to ensure
-        # it's configured identically to the sideload case.
-        serializer = field.get_serializer(envelope=True)
+        # it's configured identically to the sideload case. One difference
+        # is we need to set `envelope=True` to get the sideload-processor
+        # applied.
+        related_szr = field.get_serializer(envelope=True)
         try:
             # TODO(ryo): Probably should use field.get_attribute() but that
             #            seems to break a bunch of things. Investigate later.
-            serializer.instance = getattr(obj, field.source)
+            related_szr.instance = getattr(obj, field.source)
         except ObjectDoesNotExist:
             # See:
             # http://jsonapi.org/format/#fetching-relationships-responses-404
             # This is a case where the "link URL exists but the relationship
             # is empty" and therefore must return a 200.
             return Response({}, status=200)
 
-        return Response(serializer.data)
+        return Response(related_szr.data)
 
     def get_extra_filters(self, request):
         # Override this method to enable addition of extra filters

setup.py

@@ -4,7 +4,7 @@
 NAME = 'dynamic-rest'
 DESCRIPTION = 'Adds Dynamic API support to Django REST Framework.'
 URL = 'http://github.com/AltSchool/dynamic-rest'
-VERSION = '1.9.6'
+VERSION = '1.9.7'
 SCRIPTS = ['manage.py']
 
 setup(

tests/serializers.py

@@ -197,6 +197,9 @@ class Meta:
     favorite_pet = DynamicGenericRelationField(required=False)
 
     def get_number_of_cats(self, user):
+        if not self.context.get('request'):
+            # Used in test_api.py::test_relation_includes_context
+            raise Exception("No request object in context")
         location = user.location
         return len(location.cat_set.all()) if location else 0
 

tests/test_api.py

@@ -1152,6 +1152,16 @@ def test_relation_includes(self):
         content = json.loads(r.content.decode('utf-8'))
         self.assertTrue('locations' in content)
 
+    def test_relation_includes_context(self):
+        r = self.client.get('/locations/1/users/?include[]=number_of_cats')
+        self.assertEqual(200, r.status_code)
+
+        # Note: the DynamicMethodField for `number_of_cats` checks to
+        # ensure context is set, and raises if not. If the request
+        # succeeded and `number_of_cats` is returned, it means that check
+        # passed.
+        self.assertTrue('number_of_cats' in r.data['users'][0])
+
     def test_relation_excludes(self):
         r = self.client.get('/locations/1/users/?exclude[]=location')
         self.assertEqual(200, r.status_code)