Skip to content

Commit cbaeeba

Browse files
committed
disable unused enable_merge_ready_status
1 parent 4e4f7a9 commit cbaeeba

File tree

2 files changed

+1
-43
lines changed

2 files changed

+1
-43
lines changed

.github/workflows/pull_request.yml

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -4714,47 +4714,6 @@ jobs:
47144714
python3 -m praktika run 'Performance Comparison (arm_release, master_head, 3/3)' --workflow "PR" --ci |& tee ./ci/tmp/job.log
47154715
fi
47164716
4717-
finish_workflow:
4718-
runs-on: [self-hosted, altinity-on-demand, altinity-style-checker-aarch64]
4719-
needs: [config_workflow, dockers_build_amd, dockers_build_arm, fast_test, build_amd_tidy, build_arm_tidy, build_amd_debug, build_amd_release, build_amd_asan, build_amd_tsan, build_amd_msan, build_amd_ubsan, build_amd_binary, build_arm_release, build_arm_asan, build_arm_coverage, build_arm_binary, build_amd_darwin, build_arm_darwin, build_arm_v80compat, build_amd_freebsd, build_ppc64le, build_amd_compat, build_amd_musl, build_riscv64, build_s390x, build_loongarch64, build_fuzzers, unit_tests_asan, unit_tests_tsan, unit_tests_msan, unit_tests_ubsan, docker_server_image, docker_keeper_image, install_packages_release, install_packages_aarch64, compatibility_check_release, compatibility_check_aarch64, stateless_tests_amd_asan_distributed_plan_1_2, stateless_tests_amd_asan_distributed_plan_2_2, stateless_tests_amd_binary, stateless_tests_amd_binary_old_analyzer_s3_storage_databasereplicated_1_2, stateless_tests_amd_binary_old_analyzer_s3_storage_databasereplicated_2_2, stateless_tests_amd_binary_parallelreplicas_s3_storage, stateless_tests_amd_debug_asyncinsert_s3_storage, stateless_tests_amd_debug, stateless_tests_amd_tsan_1_3, stateless_tests_amd_tsan_2_3, stateless_tests_amd_tsan_3_3, stateless_tests_amd_msan_1_4, stateless_tests_amd_msan_2_4, stateless_tests_amd_msan_3_4, stateless_tests_amd_msan_4_4, stateless_tests_amd_ubsan, stateless_tests_amd_debug_distributed_plan_s3_storage, stateless_tests_amd_tsan_s3_storage_1_3, stateless_tests_amd_tsan_s3_storage_2_3, stateless_tests_amd_tsan_s3_storage_3_3, stateless_tests_arm_binary, stateless_tests_amd_coverage_1_6, stateless_tests_amd_coverage_2_6, stateless_tests_amd_coverage_3_6, stateless_tests_amd_coverage_4_6, stateless_tests_amd_coverage_5_6, stateless_tests_amd_coverage_6_6, bugfix_validation_integration_tests, bugfix_validation_functional_tests, stateless_tests_amd_asan_flaky_check, integration_tests_asan_old_analyzer_1_6, integration_tests_asan_old_analyzer_2_6, integration_tests_asan_old_analyzer_3_6, integration_tests_asan_old_analyzer_4_6, integration_tests_asan_old_analyzer_5_6, integration_tests_asan_old_analyzer_6_6, integration_tests_release_1_4, integration_tests_release_2_4, integration_tests_release_3_4, integration_tests_release_4_4, integration_tests_aarch64_distributed_plan_1_4, integration_tests_aarch64_distributed_plan_2_4, integration_tests_aarch64_distributed_plan_3_4, integration_tests_aarch64_distributed_plan_4_4, integration_tests_tsan_1_6, integration_tests_tsan_2_6, integration_tests_tsan_3_6, integration_tests_tsan_4_6, integration_tests_tsan_5_6, integration_tests_tsan_6_6, integration_tests_asan_flaky_check, stress_test_amd_debug, stress_test_amd_tsan, stress_test_arm_asan, stress_test_amd_ubsan, stress_test_amd_msan, upgrade_check_arm_asan, upgrade_check_amd_tsan, upgrade_check_amd_msan, upgrade_check_amd_debug, ast_fuzzer_amd_debug, ast_fuzzer_arm_asan, ast_fuzzer_amd_tsan, ast_fuzzer_amd_msan, ast_fuzzer_amd_ubsan, buzzhouse_amd_debug, buzzhouse_arm_asan, buzzhouse_amd_tsan, buzzhouse_amd_msan, buzzhouse_amd_ubsan, performance_comparison_amd_release_master_head_1_3, performance_comparison_amd_release_master_head_2_3, performance_comparison_amd_release_master_head_3_3, performance_comparison_arm_release_master_head_1_3, performance_comparison_arm_release_master_head_2_3, performance_comparison_arm_release_master_head_3_3]
4720-
if: ${{ !cancelled() }}
4721-
name: "Finish Workflow"
4722-
outputs:
4723-
data: ${{ steps.run.outputs.DATA }}
4724-
steps:
4725-
- name: Checkout code
4726-
uses: actions/checkout@v4
4727-
with:
4728-
ref: ${{ env.CHECKOUT_REF }}
4729-
4730-
- name: Setup
4731-
uses: ./.github/actions/runner_setup
4732-
4733-
- name: Prepare env script
4734-
run: |
4735-
rm -rf ./ci/tmp ./ci/tmp ./ci/tmp
4736-
mkdir -p ./ci/tmp ./ci/tmp ./ci/tmp
4737-
cat > ./ci/tmp/praktika_setup_env.sh << 'ENV_SETUP_SCRIPT_EOF'
4738-
export PYTHONPATH=./ci:.:
4739-
cat > ./ci/tmp/workflow_config_pr.json << 'EOF'
4740-
${{ needs.config_workflow.outputs.data }}
4741-
EOF
4742-
cat > ./ci/tmp/workflow_status.json << 'EOF'
4743-
${{ toJson(needs) }}
4744-
EOF
4745-
ENV_SETUP_SCRIPT_EOF
4746-
4747-
- name: Run
4748-
id: run
4749-
run: |
4750-
. ./ci/tmp/praktika_setup_env.sh
4751-
set -o pipefail
4752-
if command -v ts &> /dev/null; then
4753-
python3 -m praktika run 'Finish Workflow' --workflow "PR" --ci |& ts '[%Y-%m-%d %H:%M:%S]' | tee ./ci/tmp/job.log
4754-
else
4755-
python3 -m praktika run 'Finish Workflow' --workflow "PR" --ci |& tee ./ci/tmp/job.log
4756-
fi
4757-
47584717
##########################################################################################
47594718
##################################### ALTINITY JOBS ######################################
47604719
##########################################################################################
@@ -4941,7 +4900,6 @@ jobs:
49414900
- performance_comparison_arm_release_master_head_1_3
49424901
- performance_comparison_arm_release_master_head_2_3
49434902
- performance_comparison_arm_release_master_head_3_3
4944-
- finish_workflow
49454903
- SignRelease
49464904
- SignAarch64
49474905
- RegressionTestsRelease

ci/workflows/pull_request.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
enable_cache=True,
8080
enable_report=True,
8181
enable_cidb=True,
82-
enable_merge_ready_status=True,
82+
enable_merge_ready_status=False, # NOTE (strtgbb): we don't use this, TODO, see if we can use it
8383
enable_commit_status_on_failure=True,
8484
pre_hooks=[
8585
# can_be_trusted, # NOTE (strtgbb): relies on labels we don't use

0 commit comments

Comments
 (0)