Create new project for compose learn #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandwana001
requested changes
Sep 17, 2024
Comment on lines
+21
to
+27
| Surface( | ||
| modifier = Modifier.fillMaxSize(), | ||
| color = MaterialTheme.colors.background | ||
| ) { | ||
| Greeting("Android") | ||
| } | ||
| } |
There was a problem hiding this comment.
base project
can we complete some task in this PR?
|
Yes,
I implemented calculator but yet commit the changes
…On Tue, 17 Sept, 2024, 10:44 Akshay Nandwana, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In ComposeLearn/app/src/main/java/com/example/composelearn/MainActivity.kt
<#27 (comment)>
:
> + Surface(
+ modifier = Modifier.fillMaxSize(),
+ color = MaterialTheme.colors.background
+ ) {
+ Greeting("Android")
+ }
+ }
base project
can we complete some task in this PR?
—
Reply to this email directly, view it on GitHub
<#27 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALFQACBXEML54PYJG6J6JWDZW63E5AVCNFSM6AAAAABOIXYN26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMBYGMYDCNRQHE>
.
You are receiving this because you authored the thread.Message ID:
<AndroidEngineers/7-day-Android-App-Challenge/pull/27/review/2308301609@
github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Please include a summary of the changes you have made. Highlight the key aspects of your project.
Checklist
README.mdfile with a brief overview of the project, how to set it up, and any relevant information.Screenshots
Project README
Please ensure that your project's
README.mdis detailed and includes:Additional Notes
Is there anything else the maintainers should know about your contribution?
Thank you for your contribution!