fix room creation

Author: ArthurJCQ

src/Api/Controller/RoomController.php

@@ -30,7 +30,7 @@
 #[Route('/room', format: 'json')]
 class RoomController extends AbstractController
 {
-    public const IS_GAME_MASTERED_ROOM = 'isGameMastered';
+    public const string IS_GAME_MASTERED_ROOM = 'isGameMastered';
 
     public function __construct(
         private readonly RoomRepository $roomRepository,
@@ -60,20 +60,16 @@ public function createRoom(Request $request): JsonResponse
         $player->setUser($user);
         $player->setRoom($room);
 
-        // Check if this should be a game-mastered room
-        $isGameMastered = false;
         if ($request->getContent() !== '') {
             $data = $request->toArray();
             if (isset($data[self::IS_GAME_MASTERED_ROOM]) && $data[self::IS_GAME_MASTERED_ROOM]) {
-                $isGameMastered = true;
                 $room->setIsGameMastered(true);
                 $player->setStatus(PlayerStatus::SPECTATING);
-                // Grant ROLE_MASTER to the User, not the Player
-                $user->setRoles(['ROLE_USER', 'ROLE_MASTER']);
             }
         }
 
         $room->addPlayer($player);
+        $user->addPlayer($player);
 
         $this->roomRepository->store($room);
         $this->playerRepository->store($player);

src/Domain/Player/Entity/Player.php

@@ -360,10 +360,6 @@ public function setMissionSwitchUsed(bool $missionSwitchUsed): self
 
     public function isGameMaster(): bool
     {
-        if ($this->user === null) {
-            return false;
-        }
-
-        return in_array('ROLE_MASTER', $this->user->getRoles(), true);
+        return $this->status === PlayerStatus::SPECTATING;
     }
 }