Address review feedback for spectator mode

- Remove unused SPECTATE_ROOM voter code and related unit tests
- Add filter_var validation for spectate parameter to ensure boolean type
- Fix incomplete test by renaming and adding proper test coverage for
  existing player rejoin scenario

Author: ArthurJCQ

src/Api/Controller/UserController.php

@@ -147,7 +147,7 @@ public function patchUser(Request $request): JsonResponse
         // Handle room change
         if (array_key_exists('room', $data)) {
             $newRoomId = $data['room'];
-            $joinAsSpectator = $data['spectate'] ?? false;
+            $joinAsSpectator = filter_var($data['spectate'] ?? false, FILTER_VALIDATE_BOOLEAN);
 
             if ($newRoomId !== null) {
                 $newRoom = $this->roomRepository->findOneBy(['id' => $newRoomId]);

src/Infrastructure/Security/Voters/RoomVoter.php

@@ -5,7 +5,6 @@
 namespace App\Infrastructure\Security\Voters;
 
 use App\Domain\Player\Entity\Player;
-use App\Domain\Player\Enum\PlayerStatus;
 use App\Domain\Player\PlayerRepository;
 use App\Domain\Room\Entity\Room;
 use App\Domain\User\Entity\User;
@@ -17,7 +16,6 @@ class RoomVoter extends Voter
     public const string EDIT_ROOM = 'edit_room';
     public const string VIEW_ROOM = 'view_room';
     public const string CREATE_ROOM = 'create_room';
-    public const string SPECTATE_ROOM = 'spectate_room';
 
     public function __construct(
         private readonly PlayerRepository $playerRepository,
@@ -26,7 +24,7 @@ public function __construct(
 
     protected function supports(string $attribute, mixed $subject): bool
     {
-        if (!in_array($attribute, [self::EDIT_ROOM, self::VIEW_ROOM, self::CREATE_ROOM, self::SPECTATE_ROOM], true)) {
+        if (!in_array($attribute, [self::EDIT_ROOM, self::VIEW_ROOM, self::CREATE_ROOM], true)) {
             return false;
         }
 
@@ -51,7 +49,6 @@ protected function voteOnAttribute(string $attribute, mixed $subject, TokenInter
             self::VIEW_ROOM => $currentPlayer && $this->canView($subject, $currentPlayer),
             self::EDIT_ROOM => $currentPlayer && $this->canEdit($subject, $currentPlayer),
             self::CREATE_ROOM => !$currentPlayer && $this->canCreate($currentPlayer),
-            self::SPECTATE_ROOM => $currentPlayer && $this->canSpectate($subject, $currentPlayer),
             default => throw new \LogicException('This code should not be reached'),
         };
     }
@@ -71,12 +68,4 @@ private function canCreate(?Player $player = null): bool
     {
         return !$player?->getRoom();
     }
-
-    private function canSpectate(mixed $room, Player $player): bool
-    {
-        return $room instanceof Room
-            && $room->isAllowSpectators()
-            && $player->getRoom() === $room
-            && $player->getStatus() === PlayerStatus::SPECTATING;
-    }
 }

tests/Api/SpectatorModeCest.php

@@ -215,7 +215,7 @@ public function testGameMasterSeesEverythingDespiteSpectatingStatus(ApiTester $I
         Assert::assertArrayHasKey('missions', $response);
     }
 
-    public function testSpectatorCannotJoinRegularWhenAlreadySpectating(ApiTester $I): void
+    public function testSpectatorStatusPersistsAfterJoining(ApiTester $I): void
     {
         // Create admin and room with spectators allowed
         $I->createAdminAndUpdateHeaders($I);
@@ -236,5 +236,46 @@ public function testSpectatorCannotJoinRegularWhenAlreadySpectating(ApiTester $I
             'name' => 'Spectator',
             'status' => PlayerStatus::SPECTATING,
         ]);
+
+        // Verify status persists when fetching user info
+        $I->sendGetAsJson('/user/me');
+        $I->seeResponseContainsJson([
+            'currentPlayer' => [
+                'status' => PlayerStatus::SPECTATING->value,
+            ],
+        ]);
+    }
+
+    public function testExistingPlayerCannotRejoinAsSpectator(ApiTester $I): void
+    {
+        // Create admin and room with spectators allowed
+        $I->createAdminAndUpdateHeaders($I);
+        $I->sendPostAsJson('room');
+
+        $room = $I->grabEntityFromRepository(Room::class, ['name' => 'Admin\'s room']);
+
+        // Enable spectators
+        $I->sendPatchAsJson(sprintf('/room/%s', $room->getId()), ['allowSpectators' => true]);
+
+        // First join as regular player
+        $I->createPlayerAndUpdateHeaders($I, 'RegularPlayer');
+        $I->sendPatchAsJson('/user', ['room' => $room->getId()]);
+        $I->seeResponseCodeIsSuccessful();
+
+        // Verify player is ALIVE (not spectating)
+        $I->seeInRepository(Player::class, [
+            'name' => 'RegularPlayer',
+            'status' => PlayerStatus::ALIVE,
+        ]);
+
+        // Try to rejoin the same room as spectator (should keep existing player, not change status)
+        $I->sendPatchAsJson('/user', ['room' => $room->getId(), 'spectate' => true]);
+        $I->seeResponseCodeIsSuccessful();
+
+        // Player should still be ALIVE since they already exist in the room
+        $I->seeInRepository(Player::class, [
+            'name' => 'RegularPlayer',
+            'status' => PlayerStatus::ALIVE,
+        ]);
     }
 }