Skip to content

Commit 88b1b6d

Browse files
committed
Merge branch 'develop'
# Conflicts: # Package.resolved
2 parents d0b5c70 + 80174de commit 88b1b6d

File tree

5 files changed

+7
-274
lines changed

5 files changed

+7
-274
lines changed

Package.resolved

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Sources/CSoundpipeAudioKit/Effects/AmplitudeEnvelopeDSP.mm

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ void handleMIDIEvent(AUMIDIEvent const& midiEvent) override {
5050

5151
if (status == MIDI_NOTE_ON) {
5252
internalTrigger = midiEvent.data[2] / 127.0;
53+
} else if (status == MIDI_NOTE_OFF) {
54+
internalTrigger = 0;
5355
}
5456
}
5557

Tests/SoundpipeAudioKitTests/AmplitudeTapTests.swift

Lines changed: 0 additions & 150 deletions
This file was deleted.

Tests/SoundpipeAudioKitTests/FFTTapTests.swift

Lines changed: 0 additions & 119 deletions
This file was deleted.

Tests/SoundpipeAudioKitTests/GenericNodeTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,9 @@ class GenericNodeTests: XCTestCase {
131131
nodeParameterTest(md5: "c9ab35b7818db6a9af4edfbe2cb83927", factory: { CombFilterReverb(input) })
132132
nodeParameterTest(md5: "1d47a6a4a24667064b747cd6571d0874", factory: { CostelloReverb(input) })
133133
nodeParameterTest(md5: "6d17509eee0059105454f3cad4499586", factory: { DCBlock(input) })
134-
nodeParameterTest(md5: "55d7b2312d921aacf87d92c81bcbc806", factory: { Decimator(input) })
134+
nodeParameterTest(md5: "fd4e315defe463bd643dd0c797cfd1f2", factory: { Decimator(input) })
135135
nodeParameterTest(md5: "768665e4bad0372b7cdcc8be6040621e", factory: { Delay(input) })
136-
nodeParameterTest(md5: "2b0db813cce8ff7f2180d7a820737000", factory: { Distortion(input) })
136+
nodeParameterTest(md5: "4e240310041e20bdc886dd5eb285e89c", factory: { Distortion(input) })
137137
nodeParameterTest(md5: "a245e060a95fa63f70f01633eb00db0b", factory: { DynamicRangeCompressor(input) })
138138
nodeParameterTest(md5: "8eca17f8e436de978afc7250edd765fe", factory: { EqualizerFilter(input) })
139139
nodeParameterTest(md5: "b2eac657e060927cd0b3bfd74817c99e", factory: { FlatFrequencyResponseReverb(input) })
@@ -144,7 +144,7 @@ class GenericNodeTests: XCTestCase {
144144
nodeParameterTest(md5: "7ce66baf0b5a272dc83db83f443bd1d8", factory: { TanhDistortion(input) })
145145
nodeParameterTest(md5: "6a54cda833433325a5bd885c1375c6e2", factory: { Tremolo(input) }, m1MD5: "bb704255aad8df505d427fea08d57246")
146146
nodeParameterTest(md5: "17b152691ddaca9a74a5ab086db0e546", factory: { VariableDelay(input) })
147-
nodeParameterTest(md5: "b65a3c67da751b0f1bc6b6d604af1908", factory: { ZitaReverb(input) }, m1MD5: "78f088f0a48ab37c3d5fcfca9c9a8365")
147+
nodeParameterTest(md5: "88abdd2849431c26dab746666fcc7dbc", factory: { ZitaReverb(input) }, m1MD5: "489a410a70b87390bdc84f9f881bd260")
148148

149149
}
150150

0 commit comments

Comments
 (0)