Add comprehensive authentication documentation and multi-auth support #57
+215
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add detailed authentication configuration section to README - Document Azure AD (default), SQL Server, and Windows authentication methods - Include complete configuration examples for each authentication type - Organize configuration parameters by common and auth-specific - Update existing MCP configuration examples - Enhance index.ts with multi-authentication support - Add environment variable documentation for all auth methods
|
thank you so much i was extremely confused |
|
please merge |
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive authentication documentation and enhances the MCP server to support multiple authentication methods (Azure Active Directory, SQL Server Authentication, and Windows Authentication) for connecting to MSSQL databases.
- Enhanced authentication system to support three different methods with configurable selection
- Added comprehensive documentation with detailed configuration examples for each authentication method
- Implemented proper token management and connection reuse logic for different authentication types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/index.ts | Enhanced createSqlConfig() function to support multiple authentication methods and improved connection handling |
| README.md | Added detailed authentication configuration section with examples for all three supported methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@hlgr360 please fix Copilot comments. I hope that after this person who maintain Azure-Samples will review and approve this change. We realy need this mcp to be able to connect to local instances of mssql server. |
|
I will see that I can do it this week
… On 13. Sep 2025, at 08:58, infobric-stanislav-kondriukov ***@***.***> wrote:
infobric-stanislav-kondriukov
left a comment
(Azure-Samples/SQL-AI-samples#57)
<#57 (comment)>
@hlgr360 <https://github.com/hlgr360> please fix Copilot comments. I hope that after this person who maintain Azure-Samples will review and approve this change. We realy need this mcp to be able to connect to local instances of mssql server.
—
Reply to this email directly, view it on GitHub <#57 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABNRTXFN73XVF7IQU3E76AT3SO6BDAVCNFSM6AAAAACBHM2UH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEOBXG4YDGMJXGU>.
You are receiving this because you were mentioned.
|
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
All comments resolved |
|
Please merge pull request |
|
I did my part @laureanraybahala :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive authentication documentation and enhances the MCP server to support multiple authentication methods for connecting to MSSQL databases.
Changes Made
Documentation (README.md)
Code Enhancement (src/index.ts)
createSqlConfig()function to support multiple authentication methodsAUTH_METHODenvironment variableEnvironment Variables Added
AUTH_METHOD: Specifies authentication method (azure-ad,sql,windows)SQL_USERNAME&SQL_PASSWORD: For SQL Server authenticationUSERNAME,PASSWORD&DOMAIN: For Windows authenticationBenefits
Testing