Fixes proxy issue with browser auth

Author: gingi

desktop/src/client/core/aad/auth-provider.ts

@@ -14,6 +14,9 @@ import { AuthObserver } from "./auth-observer";
 import { shell } from "electron";
 import { AuthLoopbackClient } from "./auth-loopback-client";
 
+import "global-agent/bootstrap";
+import { ProxyNetworkClient } from "./proxy-network-client";
+
 const MSAL_SCOPES = ["user_impersonation"];
 
 export type AuthorizationResult = AuthenticationResult;
@@ -245,18 +248,21 @@ export default class AuthProvider {
     private async _createClient(tenantId: string):
         Promise<PublicClientApplication> {
         const proxyUrl = await this._loadProxyUrl();
+        let networkClient;
 
         if (proxyUrl) {
             log.info(`[${tenantId}] Proxying auth endpoints through ` +
                 proxyUrl);
+            process.env.GLOBAL_AGENT_HTTP_PROXY = proxyUrl;
+            networkClient = new ProxyNetworkClient(proxyUrl);
         }
 
         const authority =
             `${this.app.properties.azureEnvironment.aadUrl}${tenantId}/`;
 
         return new PublicClientApplication({
             system: {
-                proxyUrl
+                networkClient
             },
             auth: {
                 clientId: this.config.clientId,

desktop/src/client/core/aad/proxy-network-client.ts

@@ -0,0 +1,55 @@
+import type { INetworkModule, NetworkRequestOptions, NetworkResponse } from "@azure/msal-node";
+import * as HttpsProxyAgent from "https-proxy-agent";
+import fetch from "node-fetch";
+
+/**
+ * Placeholder for msal-node's network module which uses node-fetch to support
+ * HTTP proxy configurations with authorization
+ *
+ * @see https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/6527#issuecomment-2077953882
+ */
+export class ProxyNetworkClient implements INetworkModule {
+    private proxyAgent: HttpsProxyAgent;
+    constructor(proxyUrl: string) {
+        this.proxyAgent = new HttpsProxyAgent(proxyUrl);
+    }
+
+    sendGetRequestAsync<T>(url: string, options?: NetworkRequestOptions): Promise<NetworkResponse<T>> {
+        return this.sendRequestAsync(url, "GET", options);
+    }
+    sendPostRequestAsync<T>(url: string, options?: NetworkRequestOptions): Promise<NetworkResponse<T>> {
+        return this.sendRequestAsync(url, "POST", options);
+    }
+
+    private async sendRequestAsync<T>(
+        url: string,
+        method: "GET" | "POST",
+        options: NetworkRequestOptions = {},
+    ): Promise<NetworkResponse<T>> {
+        try {
+            const requestOptions = {
+                method: method,
+                headers: options.headers,
+                body: method === "POST" ? options.body : undefined,
+                agent: this.proxyAgent,
+            };
+
+            const response = await fetch(url, requestOptions);
+            const data = await response.json() as any;
+
+            const headersObj: Record<string, string> = {};
+            response.headers.forEach((value, key) => {
+                headersObj[key] = value;
+            });
+
+            return {
+                headers: headersObj,
+                body: data,
+                status: response.status,
+            };
+        } catch (err) {
+            console.error("Proxy request error", err);
+            throw err;
+        }
+    }
+}