fix(completion): restore typed VFS completion for tree/ls/cat (#147)

* fix(completion): use typed VFS path completions for tree/ls/cat

* test(e2e): accept typed click completion output

* fix(completion): align alias behavior and typed VFS assertions

Author: BANANASJIM

scripts/e2e-test.sh

@@ -153,7 +153,7 @@ else
   check_output "complete /d (no replay)" "no replay loaded" $RDC _complete /d
 fi
 COMP_OUTPUT=$(env _RDC_COMPLETE=bash_complete COMP_WORDS="rdc ls /d" COMP_CWORD=2 $RDC 2>&1 || true)
-if [ "$REPLAY_READY" -eq 1 ] && echo "$COMP_OUTPUT" | grep -q "/draws/"; then
+if [ "$REPLAY_READY" -eq 1 ] && echo "$COMP_OUTPUT" | grep -Eq "(/draws/|dir,/draws)"; then
   echo -e "  ${GREEN}✓${NC} click shell_complete /d → /draws/"
   PASS=$((PASS + 1))
 elif [ "$REPLAY_READY" -eq 0 ] && echo "$COMP_OUTPUT" | grep -q "no replay loaded"; then

src/rdc/commands/vfs.py

@@ -107,8 +107,8 @@ def _complete_vfs_path(
     for child in result.get("children", []):
         name = child["name"]
         if name.startswith(prefix):
-            suffix = "/" if child.get("kind") == "dir" else ""
-            items.append(CompletionItem(base + name + suffix))
+            item_type = "dir" if child.get("kind") in {"dir", "alias"} else "plain"
+            items.append(CompletionItem(base + name, type=item_type))
     return items
 
 
@@ -289,5 +289,5 @@ def complete_cmd(partial: str) -> None:
     for child in children:
         name = child["name"]
         if name.startswith(prefix):
-            suffix = "/" if child.get("kind") == "dir" else ""
+            suffix = "/" if child.get("kind") in {"dir", "alias"} else ""
             click.echo(base + name + suffix)

tests/unit/test_vfs_completion.py

@@ -43,17 +43,17 @@ def _values(items: list[CompletionItem]) -> list[str]:
 def test_complete_root_partial(monkeypatch) -> None:
     _patch(monkeypatch, _ROOT_CHILDREN)
     result = _complete_vfs_path(ctx=None, param=None, incomplete="/d")
+    assert any(item.value == "/draws" and item.type == "dir" for item in result)
     values = _values(result)
-    assert "/draws/" in values
     assert "/info" not in values
 
 
 def test_complete_root_empty(monkeypatch) -> None:
     _patch(monkeypatch, _ROOT_CHILDREN)
     result = _complete_vfs_path(ctx=None, param=None, incomplete="")
+    assert any(item.value == "/draws" and item.type == "dir" for item in result)
+    assert any(item.value == "/events" and item.type == "dir" for item in result)
     values = _values(result)
-    assert "/draws/" in values
-    assert "/events/" in values
     assert "/info" in values
     assert "/stats" in values
 
@@ -70,18 +70,22 @@ def fake_call(method: str, params: dict | None = None) -> dict:
     result = _complete_vfs_path(ctx=None, param=None, incomplete="/draws/")
     assert called_with[0]["path"] == "/draws"
     values = _values(result)
-    assert "/draws/142/" in values
-    assert "/draws/140/" in values
+    assert "/draws/142" in values
+    assert "/draws/140" in values
 
 
 def test_complete_nested_partial(monkeypatch) -> None:
     _patch(monkeypatch, _DRAWS_CHILDREN)
     result = _complete_vfs_path(ctx=None, param=None, incomplete="/draws/14")
+    typed = {item.value: item.type for item in result}
     values = _values(result)
-    assert "/draws/140/" in values
-    assert "/draws/141/" in values
-    assert "/draws/142/" in values
-    assert "/draws/200/" not in values
+    assert "/draws/140" in values
+    assert "/draws/141" in values
+    assert "/draws/142" in values
+    assert "/draws/200" not in values
+    assert typed["/draws/140"] == "dir"
+    assert typed["/draws/141"] == "dir"
+    assert typed["/draws/142"] == "dir"
 
 
 def test_complete_leaf_no_slash(monkeypatch) -> None:
@@ -95,15 +99,22 @@ def test_complete_leaf_no_slash(monkeypatch) -> None:
     values = _values(result)
     assert "/draws/142/descriptors" in values
     assert "/draws/142/binary_buf" in values
-    assert "/draws/142/shader/" in values
+    assert "/draws/142/shader" in values
+    assert any(item.value == "/draws/142/shader" and item.type == "dir" for item in result)
 
 
 def test_complete_deep_path(monkeypatch) -> None:
     _patch(monkeypatch, _DRAW_142_CHILDREN)
     result = _complete_vfs_path(ctx=None, param=None, incomplete="/draws/142/sh")
     values = _values(result)
-    assert "/draws/142/shader/" in values
-    assert "/draws/142/pipeline/" not in values
+    assert "/draws/142/shader" in values
+    assert "/draws/142/pipeline" not in values
+
+
+def test_complete_alias_treated_as_directory(monkeypatch) -> None:
+    _patch(monkeypatch, [{"name": "current", "kind": "alias"}])
+    result = _complete_vfs_path(ctx=None, param=None, incomplete="/c")
+    assert any(item.value == "/current" and item.type == "dir" for item in result)
 
 
 def test_complete_no_session(monkeypatch) -> None: