💚 add phpstan to pipeline

Author: garak

.gitattributes

@@ -1,9 +1,8 @@
-.gitattributes   export-ignore
-.github          export-ignore
-.gitignore       export-ignore
-.php_cs          export-ignore
-phpunit.xml.dist export-ignore
-README.md        export-ignore
-UPGRADE.md       export-ignore
-docs/            export-ignore
-tests/           export-ignore
+/.git*            export-ignore
+/.php_cs          export-ignore
+/phpstan*         export-ignore
+/phpunit.xml.dist export-ignore
+/README.md        export-ignore
+/UPGRADE.md       export-ignore
+/docs/            export-ignore
+/tests/           export-ignore

.github/workflows/build.yaml

@@ -5,6 +5,26 @@ on:
     push: ~
 
 jobs:
+    phpstan:
+        runs-on: ubuntu-20.04
+        name: PHPStan
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v2
+            - name: PHPStan
+              uses: docker://oskarstark/phpstan-ga
+              env:
+                  REQUIRE_DEV: true
+              with:
+                  args: analyse
+    cs-fixer:
+        runs-on: ubuntu-20.04
+        name: PHP-CS-Fixer
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v2
+            - name: Fix CS
+              uses: docker://oskarstark/php-cs-fixer-ga
     tests:
         runs-on: ubuntu-20.04
         strategy:

.php_cs

@@ -3,6 +3,7 @@
 
 $finder = PhpCsFixer\Finder::create()
     ->in([__DIR__.'/src', __DIR__.'/tests'])
+    ->notPath('FakeFixtureDependent.php')
 ;
 
 return PhpCsFixer\Config::create()

phpstan-baseline.neon

@@ -0,0 +1,17 @@
+parameters:
+	ignoreErrors:
+		-
+			message: "#^Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeDefinition\\:\\:children\\(\\)\\.$#"
+			count: 1
+			path: src/DependencyInjection/Configuration.php
+
+		-
+			message: "#^Parameter \\$manager of method Beelab\\\\TestBundle\\\\Tests\\\\FakeFixture\\:\\:load\\(\\) has invalid typehint type Doctrine\\\\Common\\\\Persistence\\\\ObjectManager\\.$#"
+			count: 1
+			path: tests/FakeFixture.php
+
+		-
+			message: "#^Parameter \\$manager of method Beelab\\\\TestBundle\\\\Tests\\\\FakeFixtureDependent\\:\\:load\\(\\) has invalid typehint type Doctrine\\\\Common\\\\Persistence\\\\ObjectManager\\.$#"
+			count: 1
+			path: tests/FakeFixtureDependent.php
+

phpstan.neon

@@ -0,0 +1,11 @@
+parameters:
+    level: 5
+    paths:
+        - src
+        - tests
+    excludePaths:
+        analyse:
+            - tests/FakeFixture.php
+            - tests/FakeFixtureDependent.php
+includes:
+    - phpstan-baseline.neon

src/Test/WebTestCase.php

@@ -203,14 +203,14 @@ protected function loadFixtures(
         } else {
             $manager = self::$em;
         }
-        $manager->getConnection()->exec('SET foreign_key_checks = 0');
+        $manager->getConnection()->executeStatement('SET foreign_key_checks = 0');
         $loader = new Loader(static::$container);
         foreach ($fixtures as $fixture) {
             $this->loadFixtureClass($loader, $namespace.$fixture);
         }
         $executor = new ORMExecutor($manager, new ORMPurger());
         $executor->execute($loader->getFixtures(), $append);
-        $manager->getConnection()->exec('SET foreign_key_checks = 1');
+        $manager->getConnection()->executeStatement('SET foreign_key_checks = 1');
     }
 
     /**
@@ -220,6 +220,7 @@ protected function loadFixtures(
     protected static function assertMailSent(int $num, string $message = ''): void
     {
         if (false !== $profile = self::$client->getProfile()) {
+            /** @var \Symfony\Bundle\SwiftmailerBundle\DataCollector\MessageDataCollector $collector */
             $collector = $profile->getCollector('swiftmailer');
             self::assertEquals($num, $collector->getMessageCount(), $message);
         } else {

tests/Test/WebTestCaseTest.php

@@ -82,7 +82,9 @@ public function testSaveOutput(): void
         $method->setAccessible(true);
         $method->invoke(self::$mock, false);
 
-        self::assertNotNull($file = $vfs->getChild('public/test.html'));
+        /** @var \org\bovigo\vfs\vfsStreamFile $file */
+        $file = $vfs->getChild('public/test.html');
+        self::assertNotNull($file);
         self::assertEquals('Response content', $file->getContent());
     }
 
@@ -204,7 +206,7 @@ public function testLoadFixtureClass(): void
     public function testLoadFixtures(): void
     {
         self::markTestIncomplete('Need to mock `loadFixtureClass` method correctly');
-
+        /*
         self::$mock
             ->expects(self::exactly(2))
             ->method('loadFixtureClass');
@@ -228,6 +230,7 @@ public function testLoadFixtures(): void
         $method = new \ReflectionMethod(self::$mock, 'loadFixtures');
         $method->setAccessible(true);
         $method->invoke(self::$mock, ['Fixture1', 'Fixture2'], 'My\\NameSpace\\', 'my.manager');
+        */
     }
 
     public function testAjax(): void
@@ -254,6 +257,7 @@ public function testCommandTest(): void
     public function testAssertMailSent(): void
     {
         self::markTestIncomplete('cannot mock static call to "assertEquals"');
+        /*
         $swiftmailerProfiler = $this->createMock(MessageDataCollector::class);
         $swiftmailerProfiler
             ->expects(self::once())
@@ -278,6 +282,7 @@ public function testAssertMailSent(): void
         $method = new \ReflectionMethod(self::$mock, 'assertMailSent');
         $method->setAccessible(true);
         $method->invoke(self::$mock, 1);
+        */
     }
 
     public function testClickLinkByData(): void