Cult Additions / Golem / Constructs

[Isaacnml]

About The Pull Request

Sharding it's in a bad spot, where it sucks for both the player being sharded, and sucks for the player who is sharding
This is an attempt to make it better for both

Letting them choose between a Cult Golem who has access to full cult abilites and some extra ones with some small drawbacks
Or to remain a Construct who has limited cult abilities

On suggestion, it also adds the ability to place a soulstone inside a soulless corpse

Why It's Good For The Game

This change improves sharding by removing some full player removals such as dying as a construct, it is no longer permanent and you get extra choices on coming back to the game

Players can now decide between becoming a Cult Golem with their own set of spells and drawbacks, or remaining a Construct with limited ways to help the cult, aswell you can now transfer soulstones into a soulless body, providing a way to turn back someone who was turned into a shade back into a human, with the drawbacks it offers aswell

Overall, this makes sharding less of a burden to the player being turned into one, since it always felt off you'd be turned into a contruct that just permanently dies upon death

Testing Photographs and Procedure

Screenshots&Videos

Not a cultist

Cultist, soulstone is empty

Cultist, soulstone with a soul

Upon death, shard is dropped again

Construct Shell Transferring works normally

Upon death of construct, soulstone is dropped again

Mind is kept intact and transferred

Dead body, soulless
Transferring soulstone into it

Regular Soulstones, purified

Transfering soulstone into a regular body

Note this cant be done in a body with a soul or/living

Changelog

🆑 Isaac, Sunshine214
add: Constructs now drop their soulstone upon death instead of fully dying
add: Cult Golem shells accept soulstones that transfer a soul into them, giving them special abilities
add: Cult Golems drop their soulstone upon death
add: Ability to transfer soulstones into soulless and dead bodies, both regular and purified soulstones
add: Cult Golem shells can be made in the altar structure or in your hands with 10 runed metal
del: You can no longer make cult golems via xenobiology, they can only be acquired by blood cultists
balance: Nerfs the Cult Golem Jaunt, reducing their cooldown in return
/:cl:

[Isaacnml]

Wasn't meant to be undrafted, still missing some important things

[EvilDragonfiend]

hmm I don't think it would solve the issue

[Isaacnml]

hmm I don't think it would solve the issue

What do you think would be a better option?

This is the only one i could think so far which seems feasible

[Isaacnml]

Main issue, original character name is not being kept and is being replaced by the construct's name

Unsure on how to fix that issue

[Isaacnml]

To-Do

Apply Dragon's suggestion about shards being able to applied into soulless/mindless corpses for any kind
Make Runic Golems drop their soulstone upon death instead of just dying
Code for the shard/naming sucks, needs a better way to be done

Possible

Buff Constructs Slightly (?

[Isaacnml]

Staying on hold, im going on vacation and dont wanna spend 24/7 fixing this for the time being

[Fronsis]

If the Chaplain purifies the souldshard they should be able to create some sort of neutral/chap golem so if the cult effectively dies they can just get people back in their bodies, i do wonder if an ideal goal would also be like:

Cult loses --> Start picking up Shards --> Send them to the chaplain(maybe something extra if there's NO chap/they also died?) --> They make runic golems but religious and pro-station--> You can ask to get a species pill to get back to your race-->You finally become back to normal? Since not many will be fans of being golems even if it's better than being the simplemob

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Isaacnml]

Undrafting just missing a few parts, most of the important code is added

[Isaacnml]

Added missing things such as holy metal purifying, as well as removed a check that could've done some conflict, you can no longer make the golems and they always drop a shard

Transferring a soul no longer permanently removes 25% of your hp
It's already bad enough that organ damage wont be cured, which is fully intended

[Rukofamicom]

Remind me this weekend if I haven't found time to review before then

[Rukofamicom]

I've had a week to think more on it, and now that I've been through the code I'm going to go ahead and say that the holy golem, holy crafting and holy metal all need to be taken out of this PR because they detract from the focus of it.

The focus of this PR is on improving the player experience for both sides of the cultist soulstone, not giving chaplains something to do with cultist materials.

[Rukofamicom]

I've said it once but I want to say it again:

I'm not at all against giving the chaplain access to a holy golem, I just don't want it as part of this PR.

[Bydth]

I can't tell for sure if you already changed this, but with the soulstone changes, sharding a character shouldn't dust them but just leave the body soulless and catatonic with a "Their soul seems to have been ripped from their body! Revival is impossible without it!" message on examine so characters can at least have a hope of being transferred back to their original bodies

[Isaacnml]

I can't tell for sure if you already changed this, but with the soulstone changes, sharding a character shouldn't dust them but just leave the body soulless and catatonic with a "Their soul seems to have been ripped from their body! Revival is impossible without it!" message on examine so characters can at least have a hope of being transferred back to their original bodies

Not currently being done, but i can change the code to hopefully do so
Not exactly sure if it'll have any issues with already existing code... and you can always just shard the body again

[Rukofamicom]

I can't tell for sure if you already changed this, but with the soulstone changes, sharding a character shouldn't dust them but just leave the body soulless

I disagree with and will be blocking this one because this makes the soulstone a single person conversion tool, rip the soul out and put it immediately back in and you have just fully converted someone.

[Isaacnml]

I can't tell for sure if you already changed this, but with the soulstone changes, sharding a character shouldn't dust them but just leave the body soulless

I disagree with and will be blocking this one because this makes the soulstone a single person conversion tool, rip the soul out and put it immediately back in and you have just fully converted someone.

Right then, gotta get the last fixes in and we should be set code-wise

Bodies being dusted but not dropping the items is not intended
Aswell i left the purified var inside, which was for the holy metal whoopsie

[Isaacnml]

Purified shades properly get their names now, instead of just being blank

[Isaacnml]

Reminder for myself, the part where it says "You're still bound to X's will" is likely not true anymore, i need to recheck it
Dont think it was ever true