Skip to content

binder_design.py is out of sync with esm 3.4.0 #395

Description

@Gu-SeongHoe

Hi,
thank you for this great work and making it publicly available

Running cookbook/tutorials/binder_design.py against esm 3.4.0 (PyPI)
hits two API mismatches.
Environment: esm 3.4.0, transformers 4.57.6, torch 2.11.0+cu130,
Python 3.12, Tutorial file from tag v3.4.0 (827ec12).

1. _esmcesmc

_load_hf_model (line 1236) does assert model._esmc is not None,
but EsmFold2ExperimentalModel now exposes esmc:

AttributeError: 'EsmFold2ExperimentalModel' object has no attribute '_esmc'

Affects lines 1236, 1237, 1238, 1312, 1315. Patched locally with
s/\._esmc\b/.esmc/g.

2. Removed forward kwargs

After that patch, fold_and_get_distogram (line 703) passes
calculate_confidence, disto_cond, disto_cond_mask, which
EsmFold2ExperimentalModel.forward() no longer accepts:

TypeError: EsmFold2ExperimentalModel.forward() got unexpected
keyword argument(s) ['calculate_confidence', 'disto_cond', 'disto_cond_mask']

None of the three appear anywhere in esm/models/esmfold2/experimental.py.

Is binder_design.py expected to work with 3.4.0, or should it be
pinned to an earlier esm version? I'd rather not just drop the kwargs
since disto_cond looks load-bearing for the design loop.

Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions