Use std::memcpy instead of memcpy

Addresses comment apache#40939 (comment)
* add include cstring

Author: alinaliBQ

cpp/src/arrow/flight/sql/odbc/flight_sql/accessors/binary_array_accessor.cc

@@ -19,6 +19,7 @@
 
 #include <algorithm>
 #include <cstdint>
+#include <cstring>
 #include "arrow/array.h"
 
 namespace driver {
@@ -44,7 +45,7 @@ inline RowStatus MoveSingleCellToBinaryBuffer(ColumnBinding* binding, BinaryArra
 
   auto* byte_buffer =
       static_cast<unsigned char*>(binding->buffer) + i * binding->buffer_length;
-  memcpy(byte_buffer, ((char*)value) + value_offset, value_length);
+  std::memcpy(byte_buffer, ((char*)value) + value_offset, value_length);
 
   if (remaining_length > binding->buffer_length) {
     result = odbcabstraction::RowStatus_SUCCESS_WITH_INFO;

cpp/src/arrow/flight/sql/odbc/flight_sql/accessors/common.h

@@ -19,6 +19,7 @@
 
 #include <algorithm>
 #include <cstdint>
+#include <cstring>
 #include "arrow/array.h"
 #include "arrow/flight/sql/odbc/flight_sql/accessors/types.h"
 #include "arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/diagnostics.h"
@@ -55,7 +56,7 @@ inline size_t CopyFromArrayValuesToBinding(ARRAY_TYPE* array, ColumnBinding* bin
   // Note that the array should already have been sliced down to the same number
   // of elements in the ODBC data array by the point in which this function is called.
   const auto* values = array->raw_values();
-  memcpy(binding->buffer, &values[starting_row], element_size * cells);
+  std::memcpy(binding->buffer, &values[starting_row], element_size * cells);
 
   return cells;
 }

cpp/src/arrow/flight/sql/odbc/flight_sql/accessors/string_array_accessor.cc

@@ -18,6 +18,7 @@
 #include "arrow/flight/sql/odbc/flight_sql/accessors/string_array_accessor.h"
 
 #include <boost/locale.hpp>
+#include <cstring>
 #include "arrow/array.h"
 #include "arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/encoding.h"
 
@@ -88,7 +89,7 @@ inline RowStatus MoveSingleCellToCharBuffer(std::vector<uint8_t>& buffer,
 
   auto* byte_buffer = static_cast<char*>(binding->buffer) + i * binding->buffer_length;
   auto* char_buffer = (CHAR_TYPE*)byte_buffer;
-  memcpy(char_buffer, ((char*)value) + value_offset, value_length);
+  std::memcpy(char_buffer, ((char*)value) + value_offset, value_length);
 
   // Write a NUL terminator
   if (binding->buffer_length >= remaining_length + sizeof(CHAR_TYPE)) {

cpp/src/arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/odbc_impl/attribute_utils.h

@@ -50,7 +50,7 @@ inline SQLRETURN GetAttributeUTF8(const std::string_view& attribute_value,
   if (output) {
     size_t output_len_before_null =
         std::min(static_cast<O>(attribute_value.size()), static_cast<O>(output_size - 1));
-    memcpy(output, attribute_value.data(), output_len_before_null);
+    std::memcpy(output, attribute_value.data(), output_len_before_null);
     reinterpret_cast<char*>(output)[output_len_before_null] = '\0';
   }
 

cpp/src/arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/odbc_impl/encoding_utils.h

@@ -45,7 +45,7 @@ inline size_t ConvertToSqlWChar(const std::string_view& str, SQLWCHAR* buffer,
   SQLLEN value_length_in_bytes = wstr.size();
 
   if (buffer) {
-    memcpy(buffer, wstr.data(),
+    std::memcpy(buffer, wstr.data(),
            std::min(static_cast<SQLLEN>(wstr.size()), buffer_size_in_bytes));
 
     // Write a NUL terminator