Fix test assertions

Author: justing-bq

cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_connection_test.cc

@@ -33,17 +33,16 @@ TEST(AttributeTests, SetAndGetAttribute) {
   const std::optional<Connection::Attribute> first_value =
       connection.GetAttribute(Connection::CONNECTION_TIMEOUT);
 
-  EXPECT_TRUE(first_value);
-
-  EXPECT_EQ(static_cast<uint32_t>(200), std::get<uint32_t>(*first_value));
+  ASSERT_TRUE(first_value);
+  ASSERT_EQ(static_cast<uint32_t>(200), std::get<uint32_t>(*first_value));
 
   connection.SetAttribute(Connection::CONNECTION_TIMEOUT, static_cast<uint32_t>(300));
 
   const std::optional<Connection::Attribute> change_value =
       connection.GetAttribute(Connection::CONNECTION_TIMEOUT);
 
-  EXPECT_TRUE(change_value);
-  EXPECT_EQ(static_cast<uint32_t>(300), std::get<uint32_t>(*change_value));
+  ASSERT_TRUE(change_value);
+  ASSERT_EQ(static_cast<uint32_t>(300), std::get<uint32_t>(*change_value));
 
   connection.Close();
 }
@@ -79,8 +78,8 @@ TEST(MetadataSettingsTest, StringColumnLengthTest) {
   const std::optional<int32_t> actual_string_column_length =
       connection.GetStringColumnLength(properties);
 
-  EXPECT_TRUE(actual_string_column_length);
-  EXPECT_EQ(expected_string_column_length, *actual_string_column_length);
+  ASSERT_TRUE(actual_string_column_length);
+  ASSERT_EQ(expected_string_column_length, *actual_string_column_length);
 
   connection.Close();
 }

cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_stream_chunk_buffer_test.cc

@@ -117,19 +117,19 @@ TEST_F(FlightStreamChunkBufferTest, TestMultipleEndpointsInt) {
     num_chunks++;
 
     int num_cols = current_chunk.data->num_columns();
-    EXPECT_EQ(8, num_cols);
+    ASSERT_EQ(8, num_cols);
 
     for (int i = 0; i < num_cols; i++) {
       auto array = current_chunk.data->column(i);
       // Each array has random length
-      EXPECT_GT(array->length(), 0);
+      ASSERT_GT(array->length(), 0);
 
       VerifyArraysContainIntsOnly(array);
     }
   }
 
   // Verify 5 batches of data is returned by each of the two endpoints.
   // In total 10 batches should be returned.
-  EXPECT_EQ(10, num_chunks);
+  ASSERT_EQ(10, num_chunks);
 }
 }  // namespace arrow::flight::sql::odbc