integrated item registry tests

Author: Bixilon

src/integration-test/kotlin/de/bixilon/minosoft/data/registries/items/VerifyIntegratedItemRegistry.kt

@@ -0,0 +1,79 @@
+/*
+ * Minosoft
+ * Copyright (C) 2020-2025 Moritz Zwerger
+ *
+ * This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/>.
+ *
+ * This software is not affiliated with Mojang AB, the original developer of Minecraft.
+ */
+
+package de.bixilon.minosoft.data.registries.items
+
+import de.bixilon.kutil.cast.CastUtil.unsafeCast
+import de.bixilon.kutil.exception.Broken
+import de.bixilon.kutil.json.JsonObject
+import de.bixilon.minosoft.config.profile.profiles.resources.ResourcesProfile
+import de.bixilon.minosoft.data.registries.item.items.DurableItem
+import de.bixilon.minosoft.data.registries.item.items.Item
+import de.bixilon.minosoft.data.registries.item.items.pixlyzer.PixLyzerItem
+import de.bixilon.minosoft.data.registries.registries.PixLyzerUtil
+import de.bixilon.minosoft.data.registries.registries.Registries
+import de.bixilon.minosoft.protocol.versions.Version
+import de.bixilon.minosoft.util.KUtil.toResourceLocation
+import de.bixilon.minosoft.util.logging.Log
+
+object VerifyIntegratedItemRegistry {
+
+    private fun compareDurability(pixlyzer: PixLyzerItem, integrated: Item, errors: StringBuilder) {
+        if (pixlyzer.maxDurability > 0 != integrated is DurableItem) {
+            errors.append("Durability ability: ${pixlyzer.identifier}")
+            return
+        }
+        if (pixlyzer.maxDurability == 0) return
+        integrated as DurableItem
+        if (pixlyzer.maxDurability != integrated.maxDurability) {
+            errors.append("Durability mismatch: ${pixlyzer.identifier}. e=${pixlyzer.maxDurability}, a=${integrated.maxDurability}")
+        }
+    }
+
+
+    private fun compare(pixlyzer: PixLyzerItem, integrated: Item, errors: StringBuilder) {
+        compareDurability(pixlyzer, integrated, errors)
+    }
+
+    fun verify(registries: Registries, version: Version) {
+        val error = StringBuilder()
+        val data = PixLyzerUtil.loadPixlyzerData(ResourcesProfile(), version)["items"]!!.unsafeCast<Map<String, JsonObject>>()
+
+        for ((id, value) in data) {
+            if (value["class"] == "AirBlock") {
+                continue
+            }
+            val identifier = id.toResourceLocation()
+            val integrated = registries.item[identifier] ?: Broken("Item $id does not exist in the registry?")
+            if (integrated is PixLyzerItem) {
+                // useless to compare
+                continue
+            }
+            val parsed = PixLyzerItem.deserialize(registries, identifier, value).unsafeCast<PixLyzerItem>()
+
+            parsed.postInit(registries)
+            parsed.inject(registries)
+
+
+            compare(parsed, integrated, error)
+        }
+
+
+        if (error.isEmpty()) {
+            return
+        }
+        error.removePrefix("\n")
+        Log.ERROR_PRINT_STREAM.println(error)
+        throw AssertionError("Does not match, see above!")
+    }
+}

src/integration-test/kotlin/de/bixilon/minosoft/data/registries/versions/registries/pixlyzer/PixLyzerLoadingTest.kt

@@ -1,6 +1,6 @@
 /*
  * Minosoft
- * Copyright (C) 2020-2023 Moritz Zwerger
+ * Copyright (C) 2020-2025 Moritz Zwerger
  *
  * This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
  *
@@ -14,6 +14,7 @@
 package de.bixilon.minosoft.data.registries.versions.registries.pixlyzer
 
 import de.bixilon.minosoft.data.registries.blocks.factory.VerifyIntegratedBlockRegistry
+import de.bixilon.minosoft.data.registries.items.VerifyIntegratedItemRegistry
 import de.bixilon.minosoft.data.registries.versions.registries.RegistryLoadingTest
 import de.bixilon.minosoft.test.ITUtil
 import org.testng.annotations.Test
@@ -26,7 +27,11 @@ abstract class PixLyzerLoadingTest(version: String) : RegistryLoadingTest(versio
         this._registries = ITUtil.loadPixlyzerData(version)
     }
 
-    fun testBlockIntegrated() {
+    fun `blocks integrated`() {
         VerifyIntegratedBlockRegistry.verify(registries, version)
     }
+
+    fun `items integrated`() {
+        VerifyIntegratedItemRegistry.verify(registries, version)
+    }
 }

src/main/java/de/bixilon/minosoft/data/container/stack/properties/DurabilityProperty.kt

@@ -41,6 +41,7 @@ data class DurabilityProperty(
         private const val DAMAGE_TAG = "Damage"
 
         fun of(item: Item, nbt: MutableJsonObject): DurabilityProperty {
+            assert(item is DurableItem && item.maxDurability > 0)
             item as DurableItem
 
             val durability = nbt.remove(DAMAGE_TAG)?.toInt()?.let { item.maxDurability - it } ?: item.maxDurability

src/main/java/de/bixilon/minosoft/data/registries/item/items/armor/materials/NetheriteArmor.kt

@@ -64,7 +64,7 @@ abstract class NetheriteArmor(resourceLocation: ResourceLocation) : ArmorItem(re
 
     open class NetheriteHelmet(resourceLocation: ResourceLocation = this.identifier) : NetheriteArmor(resourceLocation), HelmetItem {
         override val defense: Int get() = 3
-        override val maxDurability get() = 275
+        override val maxDurability get() = 407
 
         companion object : ItemFactory<NetheriteHelmet> {
             override val identifier = minecraft("netherite_helmet")

src/main/java/de/bixilon/minosoft/data/registries/item/items/pixlyzer/PixLyzerItem.kt

@@ -1,6 +1,6 @@
 /*
  * Minosoft
- * Copyright (C) 2020-2023 Moritz Zwerger
+ * Copyright (C) 2020-2025 Moritz Zwerger
  *
  * This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
  *
@@ -32,7 +32,7 @@ import de.bixilon.minosoft.util.KUtil.toResourceLocation
 open class PixLyzerItem(resourceLocation: ResourceLocation, registries: Registries, data: Map<String, Any>) : Item(resourceLocation), DurableItem, StackableItem, TintedBlock {
     override val rarity: Rarities = data["rarity"]?.toInt()?.let { Rarities[it] } ?: Rarities.COMMON
     override val maxStackSize: Int = data["max_stack_size"]?.toInt() ?: 64
-    override val maxDurability: Int = data["max_damage"]?.toInt() ?: 1
+    override val maxDurability: Int = data["max_damage"]?.toInt() ?: 0
     val isFireResistant: Boolean = data["is_fire_resistant"]?.toBoolean() ?: false
     override val translationKey: ResourceLocation = data["translation_key"]?.toResourceLocation() ?: super.translationKey
     override var tintProvider: TintProvider? = null