fix(updater): force git fetch on explicit refresh, bypassing the 5-min TTL

Author: gmmcosta15

tests/updater/test_service_unit.py

@@ -31,6 +31,44 @@ async def test_returns_all_components(self):
         assert "klipper" in result
         assert "system" in result
 
+    @pytest.mark.asyncio
+    async def test_force_bypasses_ttl(self, tmp_path: Path):
+        """force=True must always fetch even when called within the TTL window."""
+        fake_path = tmp_path / "klipper"
+        fake_path.mkdir()
+        component = ComponentConfig(name="klipper", kind="git", path=fake_path)
+        fake = ComponentStatus(name="klipper", commits_behind=0)
+        with (
+            patch(
+                "updater.service.load_components", return_value=([component], 3600.0)
+            ),
+            patch("updater.service.check_git_status", return_value=fake) as mock_check,
+        ):
+            svc = UpdateService()
+            svc._fetch_times["klipper"] = time.monotonic()
+            await svc.check_status(force=True)
+        *_, skip_fetch = mock_check.call_args.args
+        assert skip_fetch is False, "force=True must not skip the fetch"
+
+    @pytest.mark.asyncio
+    async def test_ttl_suppresses_fetch_without_force(self, tmp_path: Path):
+        """Without force, a second call within the TTL window must skip the fetch."""
+        fake_path = tmp_path / "klipper"
+        fake_path.mkdir()
+        component = ComponentConfig(name="klipper", kind="git", path=fake_path)
+        fake = ComponentStatus(name="klipper", commits_behind=0)
+        with (
+            patch(
+                "updater.service.load_components", return_value=([component], 3600.0)
+            ),
+            patch("updater.service.check_git_status", return_value=fake) as mock_check,
+        ):
+            svc = UpdateService()
+            svc._fetch_times["klipper"] = time.monotonic()
+            await svc.check_status()
+        *_, skip_fetch = mock_check.call_args.args
+        assert skip_fetch is True
+
 
 class TestStateFile:
     @pytest.mark.asyncio

updater/dbus_service.py

@@ -134,15 +134,15 @@ def _validate_component_name(self, name: str) -> bool:
             self._invalid_requests = 0
         return is_valid
 
-    async def _emit_status(self) -> None:
+    async def _emit_status(self, force: bool = False) -> None:
         """Run check_status() and emit status_ready; emits error status per component on failure."""  # noqa: E501
         if self._status_check_in_progress:
             _log.debug("_emit_status: already in progress, queueing retry")
             self._status_pending = True
             return
         self._status_check_in_progress = True
         try:
-            status = await self._svc.check_status()
+            status = await self._svc.check_status(force=force)
         except Exception as exc:  # noqa: BLE001
             _log.error("check_status failed: %s", exc)
             status = {
@@ -257,7 +257,7 @@ async def _run_recover(self, name: str, hard: bool) -> None:  # noqa: FBT001
     async def request_status(self) -> None:
         """D-Bus method: reply immediately, status arrives via status_ready signal."""
         _log.info("request_status called")
-        self._spawn(self._emit_status(), name="request_status")
+        self._spawn(self._emit_status(force=True), name="request_status")
 
     @sdbus.dbus_method_async(result_signature="b")
     async def get_busy(self) -> bool:

updater/service.py

@@ -85,8 +85,12 @@ def has_component(self, name: str) -> bool:
         """Return True if a component with the given name is registered."""
         return any(c.name == name for c in self._components)
 
-    async def check_status(self) -> dict[str, ComponentStatus]:
-        """Concurrently check status of all components."""
+    async def check_status(self, force: bool = False) -> dict[str, ComponentStatus]:
+        """Concurrently check status of all components.
+
+        force=True bypasses the fetch TTL so git fetch always runs.
+        Use for explicit user-triggered refreshes.
+        """
         results: dict[str, ComponentStatus] = {}
 
         async def _check_one(c: ComponentConfig) -> None:
@@ -98,7 +102,7 @@ async def _check_one(c: ComponentConfig) -> None:
                 now = time.monotonic()
                 async with self._git_lock:
                     last = self._fetch_times.get(c.name, 0.0)
-                    skip_fetch = (now - last) < self._FETCH_TTL
+                    skip_fetch = not force and (now - last) < self._FETCH_TTL
                     if not skip_fetch:
                         self._fetch_times[c.name] = now
                 status = await check_git_status(