Revert "BUG: Add empty implementation to convert SIMPL Json parameters to SIMPLNX Parameters"

This reverts commit e065e18.

Author: imikejackson

src/SimplnxReview/Filters/ComputeGroupingDensityFilter.cpp

@@ -1,4 +1,3 @@
-#include "ComputeGroupingDensityFilter.hpp"
 
 #include "SimplnxReview/Filters/Algorithms/ComputeGroupingDensity.hpp"
 

src/SimplnxReview/Filters/ComputeGroupingDensityFilter.hpp

@@ -34,13 +34,6 @@ class SIMPLNXREVIEW_EXPORT ComputeGroupingDensityFilter : public IFilter
   static inline constexpr StringLiteral k_CheckedFeaturesName_Key = "checked_features_name";
   static inline constexpr StringLiteral k_GroupingDensitiesName_Key = "grouping_densities_name";
 
-  /**
-   * @brief Reads SIMPL json and converts it simplnx Arguments.
-   * @param json
-   * @return Result<Arguments>
-   */
-  static Result<Arguments> FromSIMPLJson(const nlohmann::json& json);
-
   /**
    * @brief Returns the name of the filter.
    * @return

src/SimplnxReview/Filters/ComputeLocalAverageCAxisMisalignmentsFilter.hpp

@@ -35,13 +35,6 @@ class SIMPLNXREVIEW_EXPORT ComputeLocalAverageCAxisMisalignmentsFilter : public
   static inline constexpr StringLiteral k_LocalCAxisMisalignmentsName_Key = "local_c_axis_misalignments_name";
   static inline constexpr StringLiteral k_UnbiasedLocalCAxisMisalignmentsName_Key = "unbiased_local_c_axis_misalignments_name";
 
-  /**
-   * @brief Reads SIMPL json and converts it simplnx Arguments.
-   * @param json
-   * @return Result<Arguments>
-   */
-  static Result<Arguments> FromSIMPLJson(const nlohmann::json& json);
-
   /**
    * @brief Returns the name of the filter.
    * @return

src/SimplnxReview/Filters/ComputeMicroTextureRegionsFilter.hpp

@@ -30,13 +30,6 @@ class SIMPLNXREVIEW_EXPORT ComputeMicroTextureRegionsFilter : public IFilter
   static inline constexpr StringLiteral k_MicroTextureRegionNumCellsArrayName_Key = "micro_texture_region_num_cells_array_name";
   static inline constexpr StringLiteral k_MicroTextureRegionFractionOccupiedArrayName_Key = "micro_texture_region_fraction_occupied_array_name";
 
-  /**
-   * @brief Reads SIMPL json and converts it simplnx Arguments.
-   * @param json
-   * @return Result<Arguments>
-   */
-  static Result<Arguments> FromSIMPLJson(const nlohmann::json& json);
-
   /**
    * @brief Returns the name of the filter.
    * @return

src/SimplnxReview/Filters/ComputeSaltykovSizesFilter.hpp

@@ -29,13 +29,6 @@ class SIMPLNXREVIEW_EXPORT ComputeSaltykovSizesFilter : public IFilter
   static inline constexpr StringLiteral k_EquivalentDiametersArrayPath_Key = "equivalent_diameters_array_path";
   static inline constexpr StringLiteral k_SaltykovEquivalentDiametersName_Key = "saltykov_equivalent_diameters_name";
 
-  /**
-   * @brief Reads SIMPL json and converts it simplnx Arguments.
-   * @param json
-   * @return Result<Arguments>
-   */
-  static Result<Arguments> FromSIMPLJson(const nlohmann::json& json);
-
   /**
    * @brief Returns the name of the filter.
    * @return

src/SimplnxReview/Filters/GroupMicroTextureRegionsFilter.cpp

@@ -62,15 +62,16 @@ Parameters GroupMicroTextureRegionsFilter::parameters() const
   params.insert(std::make_unique<NeighborListSelectionParameter>(k_ContiguousNeighborListArrayPath_Key, "Contiguous Neighbor List", "List of contiguous neighbors for each Feature.", DataPath{},
                                                                  NeighborListSelectionParameter::AllowedTypes{DataType::int32}));
 
-  params.insertSeparator(Parameters::Separator{"Non-Contiguous Neighborhood Option"});
+  params.insertSeparator(Parameters::Separator{"Non-Contiguous Neighborhood Option"});  
   params.insertLinkableParameter(std::make_unique<BoolParameter>(k_UseNonContiguousNeighbors_Key, "Use Non-Contiguous Neighbors", "Use non-contiguous neighborhoods", false));
   params.insert(std::make_unique<NeighborListSelectionParameter>(k_NonContiguousNeighborListArrayPath_Key, "Non-Contiguous Neighbor List", "List of non-contiguous neighbors for each Feature.",
                                                                  DataPath{}, NeighborListSelectionParameter::AllowedTypes{DataType::int32}));
 
+
   params.insertSeparator(Parameters::Separator{"Random Number Seed Parameters"});
   params.insertLinkableParameter(std::make_unique<BoolParameter>(k_UseSeed_Key, "Use Seed for Random Generation", "When true the user will be able to put in a seed for random generation", false));
   params.insert(std::make_unique<NumberParameter<uint64>>(k_SeedValue_Key, "Seed", "The seed fed into the random generator", std::mt19937::default_seed));
-  params.insert(std::make_unique<DataObjectNameParameter>(k_SeedArrayName_Key, "Stored Seed Value Array Name", "Name of array holding the seed value", "_Group_MicroTexture_Regions_Seed_Value_"));
+  params.insert(std::make_unique<DataObjectNameParameter>(k_SeedArrayName_Key, "Stored Seed Value Array Name", "", "_Group_MicroTexture_Regions_Seed_Value_"));
 
   params.insertSeparator(Parameters::Separator{"Input Cell Data"});
   params.insert(std::make_unique<ArraySelectionParameter>(k_FeatureIdsArrayPath_Key, "Cell Feature Ids", "Data Array that specifies to which Feature each Element belongs", DataPath{},

src/SimplnxReview/Filters/GroupMicroTextureRegionsFilter.hpp

@@ -42,13 +42,6 @@ class SIMPLNXREVIEW_EXPORT GroupMicroTextureRegionsFilter : public IFilter
   static inline constexpr StringLiteral k_UseSeed_Key = "use_seed";
   static inline constexpr StringLiteral k_SeedValue_Key = "seed_value";
 
-  /**
-   * @brief Reads SIMPL json and converts it simplnx Arguments.
-   * @param json
-   * @return Result<Arguments>
-   */
-  static Result<Arguments> FromSIMPLJson(const nlohmann::json& json);
-
   /**
    * @brief Returns the name of the filter.
    * @return

src/SimplnxReview/Filters/InterpolateValuesToUnstructuredGridFilter.hpp

@@ -28,13 +28,6 @@ class SIMPLNXREVIEW_EXPORT InterpolateValuesToUnstructuredGridFilter : public IF
   static inline constexpr StringLiteral k_CreatedAttrMatrixName_Key = "created_attr_matrix_name";
   static inline constexpr StringLiteral k_DestinationGeometryPath_Key = "destination_geometry_path";
 
-  /**
-   * @brief Reads SIMPL json and converts it simplnx Arguments.
-   * @param json
-   * @return Result<Arguments>
-   */
-  static Result<Arguments> FromSIMPLJson(const nlohmann::json& json);
-
   /**
    * @brief
    * @return std::string

src/SimplnxReview/Filters/MergeColoniesFilter.hpp

@@ -41,13 +41,6 @@ class SIMPLNXREVIEW_EXPORT MergeColoniesFilter : public IFilter
   static inline constexpr StringLiteral k_UseSeed_Key = "use_seed";
   static inline constexpr StringLiteral k_SeedValue_Key = "seed_value";
 
-  /**
-   * @brief Reads SIMPL json and converts it simplnx Arguments.
-   * @param json
-   * @return Result<Arguments>
-   */
-  static Result<Arguments> FromSIMPLJson(const nlohmann::json& json);
-
   /**
    * @brief Returns the name of the filter.
    * @return