Use collector for dominion gatherUnknownCandidates function

Author: artoonie

src/main/java/network/brightspots/rcv/DominionCvrReader.java

@@ -247,18 +247,12 @@ public Set<RawContestConfig.Candidate> gatherUnknownCandidates(
     }
 
     Set<String> knownNames = config.getCandidateNames();
-    Set<Map.Entry<String, Candidate>> codesFoundInManifest = candidateCodesToCandidates.entrySet();
 
-    Set<RawContestConfig.Candidate> unknownCandidates = new HashSet<>();
-    for (Map.Entry<String, Candidate> entry : codesFoundInManifest) {
-      Candidate candidate = entry.getValue();
-      if (knownNames.contains(candidate.name)) {
-        continue;
-      }
-      unknownCandidates.add(new RawContestConfig.Candidate(candidate.name, entry.getKey(), false));
-    }
-
-    return unknownCandidates;
+    // Return the candidate codes that are not in the knownNames set
+    return candidateCodesToCandidates.entrySet().stream()
+            .filter(entry -> !knownNames.contains(entry.getValue().name))
+            .map(entry -> new RawContestConfig.Candidate(entry.getValue().name, entry.getKey()))
+            .collect(Collectors.toSet());
   }
 
   // parse the CVR file or files into a List of CastVoteRecords for tabulation

src/main/java/network/brightspots/rcv/RawContestConfig.java

@@ -304,6 +304,10 @@ public static class Candidate {
       this(name, null, false);
     }
 
+    Candidate(String name, String newlineSeparatedAliases) {
+      this(name, newlineSeparatedAliases, false);
+    }
+
     Candidate(String name, String newlineSeparatedAliases, boolean excluded) {
       this.name.setValue(name);
       this.excluded.setValue(excluded);