fix unit test and add precommit check

Author: nllong

.github/workflows/ci.yml

@@ -5,10 +5,35 @@ on:
   push:
 
 jobs:
+  pre-commit:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+      - name: Install Poetry
+        uses: snok/install-poetry@v1
+        with:
+          version: latest
+          virtualenvs-create: true
+          virtualenvs-in-project: true
+      - name: Load cached venv
+        id: cached-poetry-dependencies
+        uses: actions/cache@v4
+        with:
+          path: .venv
+          key: venv-${{ runner.os }}-${{ hashFiles('**/poetry.lock') }}
+      - name: Install dependencies
+        if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true'
+        run: poetry install --no-interaction --no-root
+      - name: Run pre-commit
+        run: poetry run pre-commit run --all-files
+
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: 2.7.2

.gitignore

@@ -1,18 +1,51 @@
-.idea/
-.bundle
-build
-Gemfile.lock
-gems
-.bundle
+# Operating System
 .DS_Store
+.DS_Store?
+._*
+.Spotlight-V100
+.Trashes
+ehthumbs.db
+Thumbs.db
+
+# IDEs and Editors
+.idea/
+.vscode/
+*.swp
+*.swo
+*~
+
+# Ruby
+.bundle/
 .ruby-version
+gems/
+Gemfile.lock
+
+# Python
 .python-version
+.venv/
+*.egg-info/
+__pycache__/
+*.py[cod]
+*$py.class
+*.so
+
+# Jupyter Notebooks
+.ipynb_checkpoints/
+*.ipynb
+
+# Node.js
+node_modules/
+
+# Build artifacts
+build/
+
+# Project specific
 BuildingSync.xpr
 schema_documentation.csv
 geojson.xsd
-.venv
-*.egg-info
-.ipynb_checkpoints
+gbxml.xsd
+
+# Backup files
 *.bak
-*.ipynb
-node_modules
+*.backup
+*.tmp

LICENSE.md

@@ -1,4 +1,4 @@
-BuildingSync®, Copyright (c) 2015-2021, Alliance for Sustainable Energy, LLC, and other contributors.
+BuildingSync®, Copyright (c) 2015-2025, Alliance for Sustainable Energy, LLC, and other contributors.
 
 All rights reserved.
 

spec/validation_spec.rb

@@ -1,5 +1,5 @@
 # *********************************************************************************************************
-# BuildingSync®, Copyright (c) 2015-2021, Alliance for Sustainable Energy, LLC, and other contributors.
+# BuildingSync®, Copyright (c) 2015-2025, Alliance for Sustainable Energy, LLC, and other contributors.
 #
 # All rights reserved.
 #
@@ -46,14 +46,33 @@
 
     GBXML_XSD_PATH = 'gbxml.xsd'
     GBXML_IMPORT_PATH = 'xs:schema/xs:import[@namespace = "http://www.gbxml.org/schema"]'
-    if !File.file?(GBXML_XSD_PATH) then
+    if !File.file?(GBXML_XSD_PATH) || File.size(GBXML_XSD_PATH) == 0 then
       imported_schema_locations = schema_doc.xpath(GBXML_IMPORT_PATH).collect { |nokogiri_xml_node|
         nokogiri_xml_node.attribute("schemaLocation").value
       }
       expect(imported_schema_locations.length).to eq 1
 
-      open(GBXML_XSD_PATH, 'wb') do |file|
-        file << open(imported_schema_locations[0]).read
+      begin
+        puts "Downloading gbXML schema from: #{imported_schema_locations[0]}"
+        File.open(GBXML_XSD_PATH, 'wb') do |file|
+          file << URI.open(imported_schema_locations[0]).read
+        end
+        
+        # Verify the downloaded file is valid XML
+        if File.size(GBXML_XSD_PATH) == 0
+          raise "Downloaded file is empty"
+        end
+        
+        # Test parse the downloaded XSD to ensure it's valid
+        Nokogiri::XML(File.read(GBXML_XSD_PATH)) do |config|
+          config.strict
+        end
+        puts "Successfully downloaded and validated gbXML schema"
+      rescue => e
+        puts "Failed to download gbXML schema: #{e.message}"
+        # Clean up empty or invalid file
+        File.delete(GBXML_XSD_PATH) if File.exist?(GBXML_XSD_PATH)
+        raise "Could not download valid gbXML schema from #{imported_schema_locations[0]}: #{e.message}"
       end
     end
     schema_doc.xpath(GBXML_IMPORT_PATH).collect { |nokogiri_xml_node|

src/change_log.rb

@@ -1,5 +1,5 @@
 # *********************************************************************************************************
-# BuildingSync®, Copyright (c) 2015-2021, Alliance for Sustainable Energy, LLC, and other contributors.
+# BuildingSync®, Copyright (c) 2015-2025, Alliance for Sustainable Energy, LLC, and other contributors.
 #
 # All rights reserved.
 #

src/data_dictionary.rb

@@ -1,5 +1,5 @@
 # *********************************************************************************************************
-# BuildingSync®, Copyright (c) 2015-2021, Alliance for Sustainable Energy, LLC, and other contributors.
+# BuildingSync®, Copyright (c) 2015-2025, Alliance for Sustainable Energy, LLC, and other contributors.
 #
 # All rights reserved.
 #