generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
Low PriorityA task that is of lower relative priority.A task that is of lower relative priority.enhancementEnhancement to existing feature or aspect of the project.Enhancement to existing feature or aspect of the project.standardsRelated to best practices or standards.Related to best practices or standards.
Milestone
Description
This issue covers ensuring that numpy and other libraries have their types checked correctly, where applicable. This issue comes from the following statements made by DHM:
- Neither of these is totally robust.
- See https://stackoverflow.com/questions/26921836/correct-way-to-test-for-numpy-dtype
- Suggestion: use issubdtype. https://numpy.org/doc/stable/reference/generated/numpy.issubdtype.html
Regarding:
if not interval_dates.dtype == np.dtype("datetime64[ns]"):versusif interval_dates.dtype != np.dtype("datetime64[ns]"):
See here for the original remarks.
Metadata
Metadata
Assignees
Labels
Low PriorityA task that is of lower relative priority.A task that is of lower relative priority.enhancementEnhancement to existing feature or aspect of the project.Enhancement to existing feature or aspect of the project.standardsRelated to best practices or standards.Related to best practices or standards.