Skip to content

Relying as extension cuases false positives #78

@yankovs

Description

@yankovs

Hey!

In places like these:

if magic.startswith("MS Windows shortcut") or extension == "lnk":
sample_class.update(
{"kind": "runnable", "platform": "win32", "extension": "lnk"}
)
return sample_class

We have seen that relying on the extension of the file if magic isn't what where looking for leads to FPs.

This happens with LNK files:
Image

And also for example with DEX files:
Image

I think that relying on the magic is enough in most cases. And if stronger checks are needed, it can be probably made by other means specific for the file format

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions