-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Description
Hey!
In places like these:
karton-classifier/karton/classifier/classifier.py
Lines 310 to 314 in 2c91251
| if magic.startswith("MS Windows shortcut") or extension == "lnk": | |
| sample_class.update( | |
| {"kind": "runnable", "platform": "win32", "extension": "lnk"} | |
| ) | |
| return sample_class |
We have seen that relying on the extension of the file if magic isn't what where looking for leads to FPs.
And also for example with DEX files:

I think that relying on the magic is enough in most cases. And if stronger checks are needed, it can be probably made by other means specific for the file format
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
