fix memory leaks in DBusInputStream

thorsten-klein · thorsten-klein · commit 3f163cbd269e · 2020-03-24T10:55:19.000+01:00
diff --git a/include/CommonAPI/DBus/DBusInputStream.hpp b/include/CommonAPI/DBus/DBusInputStream.hpp
@@ -19,6 +19,7 @@
 #include <string>
 #include <vector>
 #include <cstring>
+#include <memory>
 
 #include <CommonAPI/Export.hpp>
 #include <CommonAPI/InputStream.hpp>
@@ -518,7 +519,7 @@ class DBusInputStream
     char *begin_;
     size_t current_;
     size_t size_;
-    CommonAPI::DBus::DBusError* exception_;
+    std::unique_ptr<CommonAPI::DBus::DBusError> exception_;
     CommonAPI::DBus::DBusMessage message_;
 
     std::vector<uint32_t> sizes_;
diff --git a/src/CommonAPI/DBus/DBusInputStream.cpp b/src/CommonAPI/DBus/DBusInputStream.cpp
@@ -49,7 +49,7 @@ char *DBusInputStream::_readRaw(const size_t _size) {
 }
 
 void DBusInputStream::setError() {
-    exception_ = new CommonAPI::DBus::DBusError();
+    exception_ = std::unique_ptr<CommonAPI::DBus::DBusError>(new CommonAPI::DBus::DBusError());
 }
 
 void DBusInputStream::pushPosition() {

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ char *DBusInputStream::_readRaw(const size_t _size) {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`void DBusInputStream::setError() {`
`52`		`- exception_ = new CommonAPI::DBus::DBusError();`
	`52`	`+ exception_ = std::unique_ptr<CommonAPI::DBus::DBusError>(new CommonAPI::DBus::DBusError());`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`void DBusInputStream::pushPosition() {`