Merged
Conversation
c4pr1c3
reviewed
May 17, 2017
Contributor
c4pr1c3
left a comment
c4pr1c3
left a comment
There was a problem hiding this comment.
随机抽查到，给了一点建议，是否修改自己拿主意，非强制要求修改。
2017-1/ywy/图/TU.c
Outdated
2017-1/ywy/图/TU.c
Outdated
Contributor
Author
|
修改的作业中拆分了LocateVex的功能，仅输出顶点位置，添加InsertArc 函数连接两顶点 |
Contributor
|
我是专门来围观：二茶🌲的 |
cucyoyo
requested changes
Jun 2, 2017
Collaborator
cucyoyo
left a comment
cucyoyo
left a comment
There was a problem hiding this comment.
测试运行的结果与提交的结果文件不同，结果有问题，注意作业要求是每次插入和删除节点都要进行遍历输出。需要进一步理清思路和逻辑，修改相应的代码。
2017-1/ywy/排序二叉树/00.c
Outdated
2017-1/ywy/排序二叉树/00.c
Outdated
Collaborator
There was a problem hiding this comment.
这里sizeof计算的长度有问题，sizeof 是一个运算符，在代码的编译期被执行，具体可以参考C++语言爱好者众筹的这个维基页解释 http://zh.cppreference.com/w/c/language/sizeof
这里建议把变量d的声明和定义改写为数组形式，如下：
char d[] = ", ";这样，再调用sizeof运算符的时候，在代码编译期即可正确计算出该变量所占用的内存空间大小为3。
Contributor
Author
|
一次性提交的有点多，辛苦师姐了！！！ |
cucyoyo
approved these changes
Jun 19, 2017
Collaborator
cucyoyo
left a comment
cucyoyo
left a comment
There was a problem hiding this comment.
- 二叉排序树输出结果仍然有问题，如有时间继续修改，过期合并
- 排序问题整体完成没有问题，建议使用函数提高代码重用性
- Hash表建议生成更大的数据测试冲突情况
- 正确使用git：直接在需要修改的文件上进行修改即可，git会自动记录文件变化情况，不需要创建多个文件，可以将个人文件夹里过期的文件进行删除和清理，以后修改代码在现有文件中直接修改即可
2017-1/ywy/纠正版排序/Sort.c
Outdated
Collaborator
There was a problem hiding this comment.
可以将每个排序结果输出的功能封装成一个函数，增强代码重用性。
2017-1/ywy/Hash表/Hash.c
Outdated
Collaborator
There was a problem hiding this comment.
这里生成的数据永远都不会造成冲突，建议生成更大的数据以便测试冲突情况
Collaborator
|
另外需要注意自动格式化 |
Contributor
Author
|
好。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
广度优先遍历及输出最短路径