Bug Fix: image save dialog not coming up

  - image save dialog now works
  - fixed obsure case of exception with ShapeDataObj drawText
  - updated version to 2021.2.1

Author: robyww

config/app.config

@@ -3,7 +3,7 @@
 //---------------------------------------------
 BuildMajor = 2021
 BuildMinor = 2
-BuildRev = 0
+BuildRev = 1
 BuildNumber = 0
 BuildType = "Final"
 

docs/release-notes.md

@@ -5,8 +5,10 @@
 - To Access current (unstable) development - (Version _next_, unreleased) use docker tag: `nightly`
 
 ## Version 2021.2
+- 2021.2.1 (May 2021)
+  - docker tag: `latest`, `release-2021.2`, `release-2021.2.1`
 - 2021.2.0  (May 2021)
-  - docker tag: `latest`, `release-2021.2`, `release-2021.2.0`
+  - docker tag: `release-2021.2.0`
   - original release
 
 ### _Notes_
@@ -30,6 +32,11 @@
 ##### _API_ 
 - Coverage can handle tables with HMS columns ([Firefly-678](https://github.com/Caltech-IPAC/firefly/pull/1069))
 
+##### _Patches 2021.2_
+- 2021.2.1
+  - Fixed: save image dialog failing to appear
+
+
 ##### _Pull Request in this release_
 - [Bug Fixes](https://github.com/caltech-ipac/firefly/pulls?q=is%3apr+milestone%3a2021.2+label%3abug)
 - [All PRs](https://github.com/caltech-ipac/firefly/pulls?q=is%3apr++milestone%3a2021.2+)
@@ -68,7 +75,6 @@
   - firefox >= 79
   - edge >= 83
 
-
 ##### _Pull Request in this release_
 - [bug fixes](https://github.com/caltech-ipac/firefly/pulls?q=is%3apr+milestone%3a2021.1+label%3abug)
 - [all prs](https://github.com/caltech-ipac/firefly/pulls?q=is%3apr++milestone%3a2021.1+)

src/firefly/js/ui/FitsDownloadDialog.jsx

@@ -163,7 +163,7 @@ const FitsDownloadDialogForm= memo( ({isWs, popupId, groupKey}) => {
     const [{pv,plot,hasOperation,threeC,colors,currentFileNames}]= useState(getInitState);
     const fields=useBindFieldGroupToStore(groupKey);
     const band = threeC ? getFieldVal(groupKey, 'threeBandColor', colors[0]) : Band.NO_BAND.key;
-    const currentType = isImage(plot) ? (fields.fileType?.value ?? 'fits') : 'png';
+    const currentType = isImage(plot) ? (fields?.fileType?.value ?? 'fits') : 'png';
     const fileName = (currentType === 'fits') ? currentFileNames[band] : currentFileNames[currentType];
     const totalChildren = (isWs ? 3 : 2) +  (hasOperation ? 1 : 0) + (threeC ? 1 : 0);// fileType + save as + (fileLocation)
     const childH = (totalChildren*(20+mTOP));

src/firefly/js/visualize/draw/ShapeDataObj.js

@@ -855,14 +855,15 @@ function drawCircle(drawObj, ctx,  plot, drawParams) {
  */
 export function drawText(drawObj, ctx, plot, inPt, drawParams) {
     if (!inPt) return false;
+    const pv = getPlotViewById(visRoot(), plot.plotId);
+    if (!pv) return false;
 
     const {text, textOffset, renderOptions, rotationAngle, isLonLine, textBaseline= 'top',
            textAngle=0, offsetOnScreen=false}= drawObj;
     let { textAlign='start'} = drawObj;
     //the angle of the grid line
     let angle=0;
     let pvAngle=undefined;
-    const pv = getPlotViewById(visRoot(), plot.plotId);
 
     if (rotationAngle){
         const lineAngle = parseFloat( rotationAngle.substring(0,  rotationAngle.length-3));