bug fix: unselect should not be displayed when selection trace is empty

Author: tgoldina

src/firefly/js/charts/ChartsCntlr.js

@@ -404,8 +404,9 @@ function chartSelect(action) {
         // avoid updating chart twice
         // don't update before table select
         if (!chartTrigger) {
+            const hasSelected = !isEmpty(selIndexes);
             selected = newTraceFrom(data[activeTrace], selIndexes, SELECTED_PROPS);
-            dispatchChartUpdate({chartId, changes: {selected, selection: undefined}});
+            dispatchChartUpdate({chartId, changes: {hasSelected, selected, selection: undefined}});
         }
     };
 }

src/firefly/js/charts/ui/PlotlyToolbar.jsx

@@ -11,14 +11,14 @@ import {getColValidator} from './ColumnOrExpression.jsx';
 import {getColValStats} from '../TableStatsCntlr.js';
 
 function getToolbarStates(chartId) {
-    const {selection, selected, activeTrace=0, tablesources, layout, data=[]} = getChartData(chartId);
+    const {selection, hasSelected, activeTrace=0, tablesources, layout, data=[]} = getChartData(chartId);
     const {tbl_id} = get(tablesources, [activeTrace], {});
     const {columns} = get(getTblById(tbl_id), ['tableData']) || {};
     const hasFilter = tbl_id && !isEmpty(get(getTblById(tbl_id), 'request.filters'));
     const hasSelection = !isEmpty(selection);
     const traceNames = data.map((t) => t.name).toString();
     const activeTraceType = get(data, `${activeTrace}.type`);
-    return {hasSelection, hasFilter, activeTrace, activeTraceType, tbl_id, hasSelected: !!selected,
+    return {hasSelection, hasFilter, activeTrace, activeTraceType, tbl_id, hasSelected,
             dragmode: get(layout, 'dragmode'), traceNames, columns};
 }