Skip to content

Datastructure for input options and treebank correction #43

@JeltevanBoheemen

Description

@JeltevanBoheemen

correcttreebank.CorrectionParameters contains parameters required for correcting a treebank.
One of its atributes is options which is an unspecified dictionary of which some entries are required. The code needs to be followed aross various functions to discover which of these are actuall required, and where they are instantiated. Also, some keys are repeated (e.g. corr).

Proposal:

  1. Implement data structure for input options (e.g. @dataclass InputOptions)
  2. Define a subset InputOptions of required options, along with any additional required information
  3. Combine all of the parameters in 2 into the existing CorrectionParameters, remove options attribute from this class

This decouples input options from those required to correct a treebank. Only downside is that any future options have to be declared in CorrectionParameters. Actually I condiser this an upside, because it explicates the changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions