fix: missing / in url with base path when connecting Streamable HTTP MCP - #2480

I'm begging everyone to stop manually build urls and start using URL for that

Hi @asvishnyakov ,

Thank you for your feedback. I understand the importance of using the URL instead of manually building URLs. However, as I'm still getting familiar with the codebase, I would appreciate any guidance or examples you could provide on how to implement this properly.

Your help would be invaluable as I work on making these changes.

Thanks in advance!

@ggirou

new URL(path, base)

or, if base itself may already contain path:

new URL(path, base.endsWith("/") ? base : `${base}/`)

if you need to keep path or

new URL(path, base)

if you need to replace path

Chainlit already has buildEndpoint in API class which we may use, but to be honest I would like to refactor it a bit

Hi @asvishnyakov

I updated the PR to use URL

This PR is stale because it has been open for 14 days with no activity.

Hi @asvishnyakov, @asvishnyakov, @sandangel

Do you have any suggestions or feedback for merging my pull request?

Thanks!

Hi, I believe when the client miss the end / , server will redirect it to that /, is it correct? Either case should work without issue.

This PR is stale because it has been open for 14 days with no activity.

is there any update on this PR?

I'll merge it after next release