Merge pull request #257 from tribe29/devel

Release 0.17.0

Author: robin-checkmk

changelogs/changelog.yaml

@@ -186,7 +186,7 @@ releases:
       - 'Agent role - Add explicit "become: false" to the "Discover services and labels
         on host." task.'
       - Downtime module - Fix handling of parameters start_after and end_after.
-      release_summary: Bugfix Release
+      release_summary: Bugfix Release.
     fragments:
     - agent.yml
     - downtime.yml

changelogs/fragments/agent.yml

@@ -0,0 +1,50 @@
+# https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
+
+bugfixes:
+  - "Agent role - Fix delegation of activation in handler."
+
+minor_changes:
+  - "Agent role - Make forcing of foreign changes on activation by handler configurable."
+
+## Line Format
+
+# When writing a changelog entry, use the following format:
+
+# - scope - description starting with a uppercase letter and ending with a period at the very end. Multiple sentences are allowed.
+
+# The scope is usually a module or plugin name or group of modules or plugins, for example, lookup plugins. While module names can (and should) be mentioned directly (foo_module), plugin names should always be followed by the type (foo inventory plugin).
+
+# For changes that are not really scoped (for example, which affect a whole collection), use the following format:
+
+# - Description starting with an uppercase letter and ending with a dot at the very end. Multiple sentences are allowed.
+
+
+## Possible keys:
+
+# release_summary
+#     Not sure, what it does at this point, will need to test. Needs to be a single line, no list!
+
+# breaking_changes
+
+#     Changes that break existing playbooks or roles. This includes any change to existing behavior that forces users to update tasks. Displayed in both the changelogs and the Porting Guides.
+# major_changes
+
+#     Major changes to Ansible itself. Generally does not include module or plugin changes. Displayed in both the changelogs and the Porting Guides.
+# minor_changes
+
+#     Minor changes to Ansible, modules, or plugins. This includes new features, new parameters added to modules, or behavior changes to existing parameters.
+# deprecated_features
+
+#     Features that have been deprecated and are scheduled for removal in a future release. Displayed in both the changelogs and the Porting Guides.
+# removed_features
+
+#     Features that were previously deprecated and are now removed. Displayed in both the changelogs and the Porting Guides.
+# security_fixes
+
+#     Fixes that address CVEs or resolve security concerns. Include links to CVE information.
+# bugfixes
+
+#     Fixes that resolve issues.
+# known_issues
+
+#     Known issues that are currently not fixed or will not be fixed.

changelogs/fragments/release.yml

@@ -0,0 +1,9 @@
+release_summary: "Collected bugfixes."
+
+minor_changes:
+  - "contact_group module - Fix Ansible Galaxy linting findings."
+  - "discovery module - Fix Ansible Galaxy linting findings."
+  - "downtime module - Fix Ansible Galaxy linting findings."
+  - "host_group module - Fix Ansible Galaxy linting findings."
+  - "rule module - Fix Ansible Galaxy linting findings."
+  - "service_group module - Fix Ansible Galaxy linting findings."

changelogs/fragments/rule.yml

@@ -0,0 +1,47 @@
+# https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
+
+minor_changes:
+  - "Rule module - Improve rule comparison logic. No dummy rule is necessary for comparison anymore."
+
+## Line Format
+
+# When writing a changelog entry, use the following format:
+
+# - scope - description starting with a uppercase letter and ending with a period at the very end. Multiple sentences are allowed.
+
+# The scope is usually a module or plugin name or group of modules or plugins, for example, lookup plugins. While module names can (and should) be mentioned directly (foo_module), plugin names should always be followed by the type (foo inventory plugin).
+
+# For changes that are not really scoped (for example, which affect a whole collection), use the following format:
+
+# - Description starting with an uppercase letter and ending with a dot at the very end. Multiple sentences are allowed.
+
+
+## Possible keys:
+
+# release_summary
+#     Not sure, what it does at this point, will need to test. Needs to be a single line, no list!
+
+# breaking_changes
+
+#     Changes that break existing playbooks or roles. This includes any change to existing behavior that forces users to update tasks. Displayed in both the changelogs and the Porting Guides.
+# major_changes
+
+#     Major changes to Ansible itself. Generally does not include module or plugin changes. Displayed in both the changelogs and the Porting Guides.
+# minor_changes
+
+#     Minor changes to Ansible, modules, or plugins. This includes new features, new parameters added to modules, or behavior changes to existing parameters.
+# deprecated_features
+
+#     Features that have been deprecated and are scheduled for removal in a future release. Displayed in both the changelogs and the Porting Guides.
+# removed_features
+
+#     Features that were previously deprecated and are now removed. Displayed in both the changelogs and the Porting Guides.
+# security_fixes
+
+#     Fixes that address CVEs or resolve security concerns. Include links to CVE information.
+# bugfixes
+
+#     Fixes that resolve issues.
+# known_issues
+
+#     Known issues that are currently not fixed or will not be fixed.

changelogs/template.yml

@@ -1,6 +1,15 @@
-# https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
+###########################################################
+#                                                         #
+# Please use this template when writing changelogs.       #
+# Remove all comment lines, once you added your changes.  #
+# Refer to the archive, if you need examples.             #
+#                                                         #
+###########################################################
 
-## Line Format
+
+#
+## Line Format:
+#
 
 # When writing a changelog entry, use the following format:
 
@@ -13,29 +22,34 @@
 # - Description starting with an uppercase letter and ending with a dot at the very end. Multiple sentences are allowed.
 
 
+#
 ## Possible keys:
+#
+# release_summary
+#     Adds a single line release summary to the changelog.
 
 # breaking_changes
-
 #     Changes that break existing playbooks or roles. This includes any change to existing behavior that forces users to update tasks. Displayed in both the changelogs and the Porting Guides.
-# major_changes
 
+# major_changes
 #     Major changes to Ansible itself. Generally does not include module or plugin changes. Displayed in both the changelogs and the Porting Guides.
-# minor_changes
 
+# minor_changes
 #     Minor changes to Ansible, modules, or plugins. This includes new features, new parameters added to modules, or behavior changes to existing parameters.
-# deprecated_features
 
+# deprecated_features
 #     Features that have been deprecated and are scheduled for removal in a future release. Displayed in both the changelogs and the Porting Guides.
-# removed_features
 
+# removed_features
 #     Features that were previously deprecated and are now removed. Displayed in both the changelogs and the Porting Guides.
-# security_fixes
 
+# security_fixes
 #     Fixes that address CVEs or resolve security concerns. Include links to CVE information.
-# bugfixes
 
+# bugfixes
 #     Fixes that resolve issues.
-# known_issues
 
+# known_issues
 #     Known issues that are currently not fixed or will not be fixed.
+
+# Reference: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to

galaxy.yml

@@ -10,7 +10,7 @@ name: checkmk
 
 # The version of the collection. Must be compatible with semantic versioning
 
-version: 0.16.2
+version: 0.17.0
 
 # The path to the Markdown (.md) readme file. This path is relative to the root of the collection
 readme: README.md

plugins/modules/contact_group.py

@@ -424,9 +424,7 @@ def run_module():
                 ]
 
                 if len(remainings_list) > 0:
-                    changed = update_contact_groups(
-                        module, base_url, remainings_list, headers
-                    )
+                    update_contact_groups(module, base_url, remainings_list, headers)
                     msg_tokens.append(
                         "Contact groups: "
                         + " ".join([el["name"] for el in remainings_list])

plugins/modules/discovery.py

@@ -70,7 +70,6 @@
     sample: 'Host created.'
 """
 
-import json
 
 from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.urls import fetch_url

plugins/modules/downtime.py

@@ -442,13 +442,6 @@ def run_module():
         module.params.get("site"),
     )
 
-    # Decide if host- or service-downtime depending on elements of service_descriptions
-    service_descriptions = module.params.get("service_descriptions")
-    if service_descriptions == []:
-        hostdowntime = True
-    else:
-        hostdowntime = False
-
     # here, we need only the state param
     state = module.params.get("state", "present")
 

plugins/modules/host_group.py

@@ -447,9 +447,7 @@ def run_module():
                 ]
 
                 if len(remainings_list) > 0:
-                    changed = update_host_groups(
-                        module, base_url, remainings_list, headers
-                    )
+                    update_host_groups(module, base_url, remainings_list, headers)
                     msg_tokens.append(
                         "Host groups: "
                         + " ".join([el["name"] for el in remainings_list])