fix clippy lints

Author: CleanCut

src/audio.rs

@@ -251,7 +251,7 @@ pub fn queue_managed_audio_system(
             },
         });
     }
-    #[allow(clippy::for_loops_over_fallibles)]
+    #[allow(for_loops_over_fallibles)]
     if let Some(item) = game_state.audio_manager.music_queue.drain(..).last() {
         // stop any music currently playing
         if let Ok((entity, music)) = music_query.get_single() {

src/keyboard.rs

@@ -25,7 +25,7 @@ fn sync_keyboard_events(
 
     // Populate this frame's events
     for event in keyboard_input_events.read() {
-        engine.keyboard_events.push(event.clone());
+        engine.keyboard_events.push(*event);
     }
 }
 

src/mouse.rs

@@ -192,7 +192,7 @@ fn sync_mouse_events(
 
     // Populate this frame's events
     for ev in mouse_button_events.read() {
-        game_state.mouse_button_events.push(ev.clone());
+        game_state.mouse_button_events.push(*ev);
     }
     for ev in cursor_moved_events.read() {
         let mut new_event = ev.clone();
@@ -203,12 +203,12 @@ fn sync_mouse_events(
         game_state.mouse_location_events.push(new_event);
     }
     for ev in mouse_motion_events.read() {
-        let mut ev2 = ev.clone();
+        let mut ev2 = *ev;
         ev2.delta.y *= -1.0;
-        game_state.mouse_motion_events.push(ev2.clone());
+        game_state.mouse_motion_events.push(ev2);
     }
     for ev in mouse_wheel_events.read() {
-        game_state.mouse_wheel_events.push(ev.clone());
+        game_state.mouse_wheel_events.push(*ev);
     }
 }
 
@@ -225,7 +225,7 @@ fn sync_mouse_state(
     // Only changes when we get a new event, otherwise we preserve the last location.
     if let Some(event) = cursor_moved_events.read().last() {
         // Convert from bevy's window space to our game space
-        let mut location = event.position.clone();
+        let mut location = event.position;
         location.x -= game_state.window_dimensions.x * 0.5;
         location.y = -location.y + (game_state.window_dimensions.y * 0.5);
         mouse_state.location = Some(location);
@@ -235,7 +235,7 @@ fn sync_mouse_state(
     for ev in mouse_motion_events.read() {
         // Convert motion to game space direction (positive y is up, not down)
         // TODO: Check to see if this needs to be adjusted for different DPIs
-        let mut ev2 = ev.clone();
+        let mut ev2 = *ev;
         ev2.delta.y *= -1.0;
         mouse_state.motion += ev2.delta;
     }

src/physics.rs

@@ -172,18 +172,13 @@ fn collision_detection(
 /// Represents the collider (or lack thereof) of a sprite. Two sprites need to have colliders AND
 /// have their `Sprite.collision` fields set to `true` to generate collision events. See the
 /// `collider` example to create your own colliders
-#[derive(Clone, Debug, Deserialize, Serialize, PartialEq)]
+#[derive(Clone, Debug, Default, Deserialize, Serialize, PartialEq)]
 pub enum Collider {
+    #[default]
     NoCollider,
     Poly(Vec<Vec2>),
 }
 
-impl Default for Collider {
-    fn default() -> Self {
-        Collider::NoCollider
-    }
-}
-
 impl Collider {
     /// Generate a rectangular collider based on top-left and bottom-right points
     pub fn rect<T: Into<Vec2>>(topleft: T, bottomright: T) -> Self {
@@ -341,7 +336,7 @@ impl Collider {
             let poly2 = sprite2.collider.relative_to(sprite2);
             // Polygon intersection algorithm adapted from
             // https://stackoverflow.com/questions/10962379/how-to-check-intersection-between-2-rotated-rectangles
-            for poly in vec![poly1.clone(), poly2.clone()] {
+            for poly in [poly1.clone(), poly2.clone()] {
                 for (idx, &p1) in poly.iter().enumerate() {
                     let p2 = poly[(idx + 1) % poly.len()];
                     let normal = Vec2::new(p2.y - p1.y, p1.x - p2.x);