fix: 에러 핸들러 수정

Author: yongjun0511

clokey-api/src/main/java/org/clokey/domain/category/exception/CategoryErrorCode.java

@@ -8,14 +8,15 @@
 @Getter
 @AllArgsConstructor
 public enum CategoryErrorCode implements BaseErrorCode {
-    CATEGORY_NOT_FOUND(404, "존재하지 않는 카테고리입니다."),
-    CATEGORY_IN_BULK_NOT_FOUND(404, "존재하지 않는 카테고리가 포함되어 있습니다.");
+    CATEGORY_NOT_FOUND(404, "CATEGORY_4041", "존재하지 않는 카테고리입니다."),
+    CATEGORY_IN_BULK_NOT_FOUND(404, "CATEGORY_4042", "존재하지 않는 카테고리가 포함되어 있습니다.");
 
     private int status;
+    private String code;
     private String message;
 
     @Override
     public ErrorReasonDto getErrorReason() {
-        return null;
+        return ErrorReasonDto.of(status, code, message);
     }
 }

clokey-api/src/main/java/org/clokey/domain/category/repository/CategoryRepository.java

@@ -6,7 +6,7 @@
 
 public interface CategoryRepository extends JpaRepository<Category, Long> {
 
-    boolean existsByIdIn(Iterable<Long> ids);
+    long countByIdIn(Iterable<Long> ids);
 
     List<Category> findAllById(Iterable<Long> ids);
 }

clokey-api/src/main/java/org/clokey/domain/cloth/service/ClothServiceImpl.java

@@ -56,7 +56,7 @@ public ClothCreateResponse createCloths(ClothCreateRequests request) {
     }
 
     private Map<Long, Category> getCategoryMapByIds(Set<Long> ids) {
-        if (!categoryRepository.existsByIdIn(ids)) {
+        if (categoryRepository.countByIdIn(ids) != ids.size()) {
             throw new BaseCustomException(CategoryErrorCode.CATEGORY_IN_BULK_NOT_FOUND);
         }
 

clokey-api/src/test/java/org/clokey/domain/cloth/service/ClothServiceTest.java

@@ -1,17 +1,20 @@
 package org.clokey.domain.cloth.service;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.junit.jupiter.api.Assertions.*;
 import static org.mockito.BDDMockito.given;
 
 import java.util.List;
 import org.clokey.IntegrationTest;
 import org.clokey.category.entity.Category;
+import org.clokey.domain.category.exception.CategoryErrorCode;
 import org.clokey.domain.category.repository.CategoryRepository;
 import org.clokey.domain.cloth.dto.request.ClothCreateRequest;
 import org.clokey.domain.cloth.dto.request.ClothCreateRequests;
 import org.clokey.domain.cloth.repository.ClothRepository;
 import org.clokey.domain.member.repository.MemberRepository;
+import org.clokey.exception.BaseCustomException;
 import org.clokey.global.FakeAuthContext;
 import org.clokey.member.entity.Member;
 import org.clokey.member.entity.OauthInfo;
@@ -73,12 +76,27 @@ void setUp() {
             Assertions.assertAll(
                     () ->
                             assertThat(clothRepository.findById(1L).orElseThrow())
-                                    .extracting("id", "clothImageUrl", "category.id", "member.id")
-                                    .containsExactly(1L, "testClothImageUrl1", 1L, 1L),
+                                    .extracting("lothImageUrl", "category.id", "member.id")
+                                    .containsExactly("testClothImageUrl1", 1L, 1L),
                     () ->
                             assertThat(clothRepository.findById(2L).orElseThrow())
-                                    .extracting("id", "clothImageUrl", "category.id", "member.id")
-                                    .containsExactly(1L, "testClothImageUrl2", 1L, 1L));
+                                    .extracting("clothImageUrl", "category.id", "member.id")
+                                    .containsExactly("testClothImageUrl2", 1L, 1L));
+        }
+
+        @Test
+        void 카테고리가_존재하지_않을_경우_예외가_발생한다() {
+            // given
+            ClothCreateRequests request =
+                    new ClothCreateRequests(
+                            List.of(
+                                    new ClothCreateRequest("testClothImageUrl1", 1L),
+                                    new ClothCreateRequest("testClothImageUrl2", 999L)));
+
+            // when & then
+            assertThatThrownBy(() -> clothService.createCloths(request))
+                    .isInstanceOf(BaseCustomException.class)
+                    .hasMessage(CategoryErrorCode.CATEGORY_IN_BULK_NOT_FOUND.getMessage());
         }
     }
 }

clokey-common/src/main/java/org/clokey/exception/BaseCustomException.java

@@ -1,14 +1,17 @@
 package org.clokey.exception;
 
-import lombok.AllArgsConstructor;
 import lombok.Getter;
 import org.clokey.dto.ErrorReasonDto;
 
 @Getter
-@AllArgsConstructor
 public class BaseCustomException extends RuntimeException {
 
-    private BaseErrorCode code;
+    private final BaseErrorCode code;
+
+    public BaseCustomException(BaseErrorCode code) {
+        super(code.getErrorReason().message());
+        this.code = code;
+    }
 
     public ErrorReasonDto getErrorReasonDto() {
         return this.code.getErrorReason();