Skip to content
This repository was archived by the owner on Nov 2, 2020. It is now read-only.

Commit 883ab73

Browse files
committed
Small refactoring
1 parent 7e9ba09 commit 883ab73

File tree

7 files changed

+33
-28
lines changed

7 files changed

+33
-28
lines changed

src/main/java/com/clusterws/Channel.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import java.util.List;
44

55
public class Channel {
6-
public interface IChannelListener{
6+
public interface IChannelListener {
77
void onDataReceived(String channelName, Object data);
88
}
99

@@ -16,13 +16,13 @@ public Channel(String channelName, ClusterWS clusterWS) {
1616
mClusterWS = clusterWS;
1717
}
1818

19-
public Channel watch(IChannelListener listener){
19+
public Channel watch(IChannelListener listener) {
2020
mChannelListener = listener;
2121
return this;
2222
}
2323

24-
public Channel publish(Object data){
25-
mClusterWS.send(mChannelName,data,"publish");
24+
public Channel publish(Object data) {
25+
mClusterWS.send(mChannelName, data, "publish");
2626
return this;
2727
}
2828

@@ -42,7 +42,7 @@ void onMessage(Object data) {
4242
}
4343
}
4444

45-
void subscribe(){
46-
mClusterWS.send("subscribe",mChannelName,"system");
45+
void subscribe() {
46+
mClusterWS.send("subscribe", mChannelName, "system");
4747
}
4848
}

src/main/java/com/clusterws/Emitter.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,28 +3,28 @@
33
import java.util.concurrent.ConcurrentHashMap;
44

55
class Emitter {
6-
private ConcurrentHashMap<String,IEmitterListener> mEvents;
6+
private ConcurrentHashMap<String, IEmitterListener> mEvents;
77

88
Emitter() {
99
mEvents = new ConcurrentHashMap<>();
1010
}
1111

12-
void addEventListener(String event, IEmitterListener listener){
13-
if (mEvents.containsKey(event)){
14-
mEvents.replace(event,listener);
12+
void addEventListener(String event, IEmitterListener listener) {
13+
if (mEvents.containsKey(event)) {
14+
mEvents.replace(event, listener);
1515
} else {
16-
mEvents.put(event,listener);
16+
mEvents.put(event, listener);
1717
}
1818
}
1919

20-
void emit(String event, Object object){
20+
void emit(String event, Object object) {
2121
IEmitterListener listener = mEvents.get(event);
22-
if (listener != null){
22+
if (listener != null) {
2323
listener.onDataReceived(object);
2424
}
2525
}
2626

27-
void removeAllEvents(){
27+
void removeAllEvents() {
2828
mEvents = new ConcurrentHashMap<>();
2929
}
3030
}

src/main/java/com/clusterws/IClusterWSListener.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
public interface IClusterWSListener {
44
void onConnected();
5+
56
void onError(Exception exception);
7+
68
void onDisconnected(int code, String reason);
79
}

src/main/java/com/clusterws/ISocketEvents.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,13 @@
44

55
public interface ISocketEvents {
66
void onOpen();
7+
78
void onError(Exception exception);
9+
810
void onClose(int code, String reason);
11+
912
void onBinaryMessage(ByteBuffer bytes);
13+
1014
void onMessage(String message);
1115

1216
}

src/main/java/com/clusterws/MessageHandler.java

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,15 @@
44
import com.alibaba.fastjson.JSONArray;
55
import com.alibaba.fastjson.JSONObject;
66

7-
import java.util.ArrayList;
87
import java.util.List;
98
import java.util.TimerTask;
109

1110

1211
class MessageHandler {
13-
String messageEncode(String event, Object data, String type){
12+
String messageEncode(String event, Object data, String type) {
1413
JSONObject jsonObject = new JSONObject();
1514
JSONArray jsonArray = new JSONArray();
16-
switch (type){
15+
switch (type) {
1716
case "publish":
1817
jsonArray.add("p");
1918
jsonArray.add(event);
@@ -27,18 +26,18 @@ String messageEncode(String event, Object data, String type){
2726
jsonObject.put("#", jsonArray);
2827
return jsonObject.toJSONString();
2928
case "system":
30-
switch (event){
29+
switch (event) {
3130
case "subscribe":
3231
jsonArray.add("s");
3332
jsonArray.add("s");
3433
jsonArray.add(data);
35-
jsonObject.put("#",jsonArray);
34+
jsonObject.put("#", jsonArray);
3635
return jsonObject.toJSONString();
3736
case "unsubscribe":
3837
jsonArray.add("s");
3938
jsonArray.add("u");
4039
jsonArray.add(data);
41-
jsonObject.put("#",jsonArray);
40+
jsonObject.put("#", jsonArray);
4241
return jsonObject.toJSONString();
4342
}
4443
case "ping":
@@ -48,9 +47,9 @@ String messageEncode(String event, Object data, String type){
4847
}
4948
}
5049

51-
void messageDecode(final ClusterWS socket, String message){
50+
void messageDecode(final ClusterWS socket, String message) {
5251
JSONArray jsonArray = JSON.parseObject(message).getJSONArray("#");
53-
switch (jsonArray.getString(0)){
52+
switch (jsonArray.getString(0)) {
5453
case "p":
5554
//
5655
List<Channel> channelArrayList = socket.getChannels();
@@ -64,10 +63,10 @@ void messageDecode(final ClusterWS socket, String message){
6463
}
6564
break;
6665
case "e":
67-
socket.getEmitter().emit(jsonArray.getString(1),jsonArray.get(2));
66+
socket.getEmitter().emit(jsonArray.getString(1), jsonArray.get(2));
6867
break;
6968
case "s":
70-
if (jsonArray.getString(1).equals("c")){
69+
if (jsonArray.getString(1).equals("c")) {
7170
socket.getPingHandler().getPingTimer().scheduleAtFixedRate(new TimerTask() {
7271
@Override
7372
public void run() {
@@ -78,10 +77,10 @@ public void run() {
7877
cancel();
7978
}
8079
}
81-
},0,jsonArray.getJSONObject(2).getInteger("ping"));
80+
}, 0, jsonArray.getJSONObject(2).getInteger("ping"));
8281
boolean useBinary = jsonArray.getJSONObject(2).getBoolean("binary");
8382
socket.setUseBinary(useBinary);
84-
if (socket.getClusterWSListener() != null){
83+
if (socket.getClusterWSListener() != null) {
8584
socket.getClusterWSListener().onConnected();
8685
}
8786
}

src/main/java/com/clusterws/PingHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ void incrementMissedPing() {
1515
mMissedPing++;
1616
}
1717

18-
void setMissedPingToZero(){
18+
void setMissedPingToZero() {
1919
mMissedPing = 0;
2020
}
2121

src/main/java/com/clusterws/Socket.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public void onMessage(String message) {
2727

2828
@Override
2929
public void onClose(int code, String reason, boolean remote) {
30-
mSocketEvents.onClose(code,reason);
30+
mSocketEvents.onClose(code, reason);
3131
}
3232

3333
@Override

0 commit comments

Comments
 (0)