remove some warnings

Author: Orciument

backend/src/lib.rs

@@ -2,7 +2,6 @@ use crate::commands::command_executor_service::{ChatMessage, CommandExecutorServ
 use twitch::twitch_service::{TwitchConfig, TwitchService};
 use crate::db::ProdDB;
 use serde::{Deserialize, Serialize};
-use service_oauth::oauth_service::OAuthService;
 use sqlx::MySqlPool;
 use std::str::FromStr;
 use std::sync::{Arc, OnceLock, RwLock};
@@ -11,6 +10,8 @@ use tokio::runtime::Handle;
 use tokio::sync::broadcast::error::RecvError;
 use url::Url;
 use state::{FullState, L1State, L2State, WebserverState};
+use crate::service_oauth::oauth_service::OAuthService;
+use crate::session_service::SessionService;
 
 mod webserver_authentication;
 mod axum;
@@ -42,8 +43,8 @@ pub async fn start() {
             panel_auth_twitch_client_id: "zmxjjn3xmncg8ewew6tjk08tub26bb".to_string()
         }),
         command_executor_service: CommandExecutorService::new(&prod_db).await,
-        oauth_service: Default::default(),
-        session_service: Default::default(),
+        oauth_service: OAuthService::new(),
+        session_service: SessionService::new(),
         prod_db,
     });
 

backend/src/service_oauth/oauth_endpoint.rs

@@ -6,7 +6,6 @@ use axum::response::IntoResponse;
 use axum::response::Result as AxResult;
 use axum::Json;
 use log::error;
-use reqwest::StatusCode;
 use serde::Deserialize;
 use crate::state::L1Arc;
 

backend/src/service_oauth/oauth_service.rs

@@ -12,7 +12,6 @@ struct OauthRequest {
     return_channel: Sender<String>,
 }
 
-#[derive(Default)]
 pub struct OAuthService {
     active_requests: RwLock<Vec<OauthRequest>>,
 }
@@ -35,6 +34,12 @@ pub type OauthState = str;
 pub type AuthorizationUrlBuilder = dyn (for<'a> Fn(&'a RedirectUrl, &'a OauthState) -> AuthorizationUrl) + Send + Sync;
 
 impl OAuthService {
+    pub fn new() -> OAuthService {
+        OAuthService {
+            active_requests: RwLock::new(Vec::new()),
+        }
+    }
+    
     pub fn new_oauth_request<B>(&self, service_name: impl Into<String>, account_name: impl Into<String>, authorization_url: B) -> String
     where B: (for<'a> Fn(&'a RedirectUrl, &'a OauthState) -> AuthorizationUrl) + Send + Sync + Clone + 'static,
     {

backend/src/twitch/twitch_service.rs

@@ -12,7 +12,6 @@ use log::{info, warn};
 use tokio::runtime::Handle;
 use tokio::sync::{Mutex, RwLock};
 use twitch_highway::TwitchAPI;
-use crate::service_oauth::oauth_service::{AuthorizationUrlBuilder, OauthState, RedirectUrl};
 
 #[derive(Default, Deserialize, Clone)]
 pub(crate) struct OauthCredential {
@@ -136,7 +135,6 @@ impl TwitchService {
 
     async fn check_or_get_oauth(cred: &OauthCredential, _db: &ProdDB, twitch_config: &TwitchConfig) -> Result<TwitchCredentialStatus, anyhow::Error> {
         const FINAL_ERROR: &str = "Could not get new oauth token, bad credentials, needs reauthentication";
-        // is first thread, do validation/refreshing
         let mut errors = vec![];
         match validate_token(cred.access_token.as_str()).await {
             Ok(Some(_validation)) => {