refactor: throw error for negative count in repeat() to avoid ambiguous return values

Author: HadiVahidi20

Sprint-3/2-practice-tdd/get-ordinal-number.js

@@ -1,6 +1,6 @@
 function getOrdinalNumber(num) {
-  const twoLastDig = num % 100;
-  if (twoLastDig === 11 || twoLastDig === 12 || twoLastDig === 13) {
+  const itsTwoLastDigs = num % 100;
+  if (itsTwoLastDigs === 11 || itsTwoLastDigs === 12 || itsTwoLastDigs === 13) {
     return num + "th";
   }
 

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

@@ -8,36 +8,35 @@ const getOrdinalNumber = require("./get-ordinal-number");
 // When the number is 1,
 // Then the function should return "1st"
 
-test("should return '1st' for 1", () => {
-  expect(getOrdinalNumber(1)).toEqual("1st");
-});
-test("should return '11th' for 11", () => {
-  expect(getOrdinalNumber(11)).toEqual("11th");
-});
-
-test("should return '2nd' for 2", () => {
-  expect(getOrdinalNumber(2)).toEqual("2nd");
-});
-
-
-test("should return '23rd' for 23rd", () => {
-  expect(getOrdinalNumber(23)).toEqual("23rd");
-});
-test("should return '3rd' for 3", () => {
-  expect(getOrdinalNumber(3)).toEqual("3rd");
-});
-test("should return '4th' for 4", () => {
-  expect(getOrdinalNumber(4)).toEqual("4th");
-});
-
-test("should return '12th' for 12", () => {
-  expect(getOrdinalNumber(12)).toEqual("12th");
-});
-test("should return '13th' for 13", () => {
-  expect(getOrdinalNumber(13)).toEqual("13th");
-});
-
-
-test("should return '101st' for 101", () => {
-  expect(getOrdinalNumber(101)).toEqual("101st");
+describe("getOrdinalNumber", () => {
+  test("append 'st' to numbers ending in 1 expect 11", () => {
+    expect(getOrdinalNumber(1)).toEqual("1st");
+    expect(getOrdinalNumber(101)).toEqual("101st");
+  });
+  test("should return '11th' for 11", () => {
+    expect(getOrdinalNumber(11)).toEqual("11th");
+  });
+
+  test("append 'rd' to numbers ending in 3", () => {
+    expect(getOrdinalNumber(3)).toEqual("3rd");
+    expect(getOrdinalNumber(23)).toEqual("23rd");
+    expect(getOrdinalNumber(33)).toEqual("33rd");
+    expect(getOrdinalNumber(103)).toEqual("103rd");
+  });
+  test("should return '4th' for 4", () => {
+    expect(getOrdinalNumber(4)).toEqual("4th");
+  });
+
+  test("should return '12th' for 12", () => {
+    expect(getOrdinalNumber(12)).toEqual("12th");
+  });
+  test("should return '13th' for 13", () => {
+    expect(getOrdinalNumber(13)).toEqual("13th");
+  });
+
+  test("append 'nd' to numbers ending in 2, except those ending in 12", () => {
+    expect(getOrdinalNumber(2)).toEqual("2nd");
+    expect(getOrdinalNumber(22)).toEqual("22nd");
+    expect(getOrdinalNumber(132)).toEqual("132nd");
+  });
 });

Sprint-3/2-practice-tdd/repeat-str.js

@@ -1,11 +1,10 @@
-function repeat(str,count) {
-  if (count=== 0){
-    return ""
-  }
-  if(count<0){
-    return "invalid"
+function repeat(str, count) {
+  if (count < 0) {
+    throw new Error("count must be non-negative");
   }
   return str.repeat(count);
 }
 
 module.exports = repeat;
+
+