London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Acoursework/sprint 3 #699

HoussamLh · 2025-09-07T14:20:29Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This pull request for syn my fork and updating my branch.

Questions

Please, Let me know if there is anything else went wrong?

…dle, and last names.

…om file path string using slice.

…ween minimum and maximum.

…tion.

Added comments to exclude instructional lines from execution.

Updated age variable to let to allow incrementing its value

Declare variable before using in template string.

Add comments explaining slice error and fix by converting number to string

…umerator cases and add stretch scenarios for isProperFraction edge case testing

…id cards and throw error for invalid ones

…ractions

…e cards; throw error for invalid cards

…alid input

… string

- Return proper suffixes for 1st, 2nd, 3rd, and others (e.g., 4th, 11th, 23rd) - Added Jest tests for various edge cases including teens (11th-13th) - Improved function to handle general inputs dynamically

- Added str and count parameters to repeat function - Used String.repeat to repeat str count times - Throws error if count is negative - Added tests for count = 1, 0, and negative values

…iled comments and explanations

cjyuan · 2025-09-07T23:00:10Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

+  const number = Number(rank);
+  if (number >= 2 && number <= 9) return number;


Does your function return the value you expected from each of the following function calls?

getCardValue("0x02♠"); getCardValue("2.1♠"); getCardValue("0002♠");

cjyuan · 2025-09-07T23:02:07Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

+test("should return 5 for Five of Hearts", () => {
+  expect(getCardValue("5♥")).toEqual(5);
+});
+
+test("should return 10 for Ten of Diamonds", () => {
+  expect(getCardValue("10♦")).toEqual(10);
+});


When preparing tests, we should ensure the tests cover all possible cases. If we specify a test for individual card, we will need about 53 tests to cover all possible cases. Instead, we could consider classifying all possible values into different categories, and then within each category we test some samples.

For example, one possible category for getCardValue() is, "should return the value of number cards (2-10)", and we can prepare the test as

test("should return the value of number cards (2-10)", () => { expect(getCardValue("2♣︎")).toEqual(2); expect(getCardValue("5♠")).toEqual(5); expect(getCardValue("10♥")).toEqual(10); // Note: We could also use a loop to check all values from 2 to 10. });

cjyuan · 2025-09-07T23:02:37Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

+test("should return 10 for Jack of Clubs", () => {
+  expect(getCardValue("J♣")).toEqual(10);
+});
+
+test("should return 10 for Queen of Spades", () => {
+  expect(getCardValue("Q♠")).toEqual(10);
+});
+
+test("should return 10 for King of Hearts", () => {
+  expect(getCardValue("K♥")).toEqual(10);
+});


We could generalise this test to "should return 10 for face cards (J, Q, K)" and check all three ranks J, Q, K).

cjyuan · 2025-09-07T23:05:33Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

+
+test("should return '2nd' for 2", () => {
+  expect(getOrdinalNumber(2)).toEqual("2nd");
+});
+
+test("should return '3rd' for 3", () => {
+  expect(getOrdinalNumber(3)).toEqual("3rd");
+});
+
+test("should return '4th' for 4", () => {
+  expect(getOrdinalNumber(4)).toEqual("4th");
+});
+
+test("should return '11th' for 11", () => {
+  expect(getOrdinalNumber(11)).toEqual("11th");
+});


These tests are not comprehensive; they do not quite cover all possible cases.

To ensure thorough testing, we need broad scenario coverage. Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories. Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.

For example, we can prepare a test for numbers 2, 22, 132, etc. as

test("append 'nd' to numbers ending in 2, except those ending in 12", () => { expect( getOrdinalNumber(2) ).toEqual("2nd"); expect( getOrdinalNumber(22) ).toEqual("22nd"); expect( getOrdinalNumber(132) ).toEqual("132nd"); });

cjyuan · 2025-09-07T23:11:22Z

Sprint-3/3-mandatory-practice/implement/repeat.test.js

Because of a bug, I don't think this script can be executed successfully. Can you try executing this file and fix the error?

In addition, it is a good practice to delete unused code when submitting the code for review.

HoussamLh and others added 25 commits June 17, 2025 23:30

explain Increment count variable by 1 after initialization.

2dd0a78

Create initials variable by extracting first characters of first, mid…

1bc5c74

…dle, and last names.

create two variable and Extract directory and file extension parts fr…

b16d048

…om file path string using slice.

Add comments explaining how num is calculated as a random integer bet…

625c114

…ween minimum and maximum.

Add explanation for incrementing count variable by 1 after initializa…

f5522e7

…tion.

Update 0.js

2f17199

Added comments to exclude instructional lines from execution.

Update 1.js

5e31d7c

Updated age variable to let to allow incrementing its value

Update 2.js

5cf1cfd

Declare variable before using in template string.

Update 3.js

2d1e8dd

Add comments explaining slice error and fix by converting number to string

implement getAngleType function with all angle cases and tests

4723bb9

implement isProperFraction with tests for positive, negative, equal n…

85a7125

…umerator cases and add stretch scenarios for isProperFraction edge case testing

Implement getCardValue to return correct blackjack values for all val…

a6dd884

…id cards and throw error for invalid ones

Export complete getAngleType() function for Jest testing

cb53f9a

Add Jest tests for all angle types in getAngleType()

5a07227

Implement isProperFraction to handle proper, improper, and negative f…

a417fa0

…ractions

Add unit tests for isProperFraction covering all key scenarios

461d0b6

Implement getCardValue function with support for number, face, and ac…

057740b

…e cards; throw error for invalid cards

Add tests for getCardValue covering number cards, face cards, and inv…

48444ef

…alid input

Revert Sprint-1 folder to CYF's original version

633a7af

Implement countChar function to count occurrences of a character in a…

6d8d7bb

… string

Implement getOrdinalNumber to handle ordinal suffixes correctly

50eaeb4

- Return proper suffixes for 1st, 2nd, 3rd, and others (e.g., 4th, 11th, 23rd) - Added Jest tests for various edge cases including teens (11th-13th) - Improved function to handle general inputs dynamically

Implement repeat function with parameters and error handling

e2c7e37

- Added str and count parameters to repeat function - Used String.repeat to repeat str count times - Throws error if count is negative - Added tests for count = 1, 0, and negative values

Implement find function to locate character index in string with deta…

276c348

…iled comments and explanations

just to writing a missing bits.

28dfefd

Implement credit card validator function

c3ed0d1

HoussamLh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 7, 2025

cjyuan reviewed Sep 7, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 7, 2025

HoussamLh closed this Sep 9, 2025

HoussamLh deleted the acoursework/sprint-3 branch September 9, 2025 16:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Acoursework/sprint 3 #699

London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Acoursework/sprint 3 #699

Uh oh!

HoussamLh commented Sep 7, 2025

Uh oh!

cjyuan Sep 7, 2025

Uh oh!

cjyuan Sep 7, 2025

Uh oh!

cjyuan Sep 7, 2025

Uh oh!

cjyuan Sep 7, 2025

Uh oh!

cjyuan Sep 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const number = Number(rank);
		if (number >= 2 && number <= 9) return number;

Uh oh!

London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Acoursework/sprint 3 #699

London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Acoursework/sprint 3 #699

Uh oh!

Conversation

HoussamLh commented Sep 7, 2025

Uh oh!

cjyuan Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants