Skip to content

Commit 14718a2

Browse files
authored
update links (#100)
1 parent 0f26e63 commit 14718a2

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

src/Codeception/Module/WebDriver.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2195,7 +2195,7 @@ public function dontSeeInTitle($title)
21952195
/**
21962196
* Accepts the active JavaScript native popup window, as created by `window.alert`|`window.confirm`|`window.prompt`.
21972197
* Don't confuse popups with modal windows,
2198-
* as created by [various libraries](http://jster.net/category/windows-modals-popups).
2198+
* as created by [various libraries](https://jster.net/category/windows-modals-popups).
21992199
*/
22002200
public function acceptPopup(): void
22012201
{
@@ -3446,15 +3446,15 @@ private function cookieDomainMatchesConfigUrl(array|WebDriverCookie $cookie): bo
34463446
$domain = parse_url($this->config['url'], PHP_URL_HOST);
34473447

34483448
// Remove the leading '.' as per spec in RFC 6265.
3449-
// http://tools.ietf.org/html/rfc6265#section-5.2.3
3449+
// https://tools.ietf.org/html/rfc6265#section-5.2.3
34503450
$cookieDomain = ltrim($cookie['domain'], '.');
34513451
// Domain not set or exact match.
34523452
if (!$cookieDomain || !strcasecmp($domain, $cookieDomain)) {
34533453
return true;
34543454
}
34553455

34563456
// Matching the subdomain according to RFC 6265.
3457-
// http://tools.ietf.org/html/rfc6265#section-5.1.3
3457+
// https://tools.ietf.org/html/rfc6265#section-5.1.3
34583458
if (filter_var($domain, FILTER_VALIDATE_IP)) {
34593459
return false;
34603460
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<html>
22
<body>
3-
<a href="http://codeception.com/">Next</a>
3+
<a href="https://codeception.com/">Next</a>
44
</body>
55
</html>

tests/web/TestsForWeb.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ public function testSeeLink()
119119
{
120120
$this->module->amOnPage('/external_url');
121121
$this->module->seeLink('Next');
122-
$this->module->seeLink('Next', 'http://codeception.com/');
122+
$this->module->seeLink('Next', 'https://codeception.com/');
123123
// Without TLD and trailing slash
124-
$this->module->dontSeeLink('Next', 'http://codeception');
124+
$this->module->dontSeeLink('Next', 'https://codeception');
125125
}
126126

127127
public function testDontSeeLink()
@@ -152,7 +152,7 @@ public function testSeeLinkFailsIfHrefDoesNotMatchExactly()
152152
$this->expectException('PHPUnit\Framework\AssertionFailedError');
153153
$this->expectExceptionMessage("No links containing text 'Next' and URL 'http://codeception' were found in page /external_url");
154154
$this->module->amOnPage('/external_url');
155-
$this->module->seeLink('Next', 'http://codeception');
155+
$this->module->seeLink('Next', 'https://codeception');
156156
}
157157

158158
public function testDontSeeLinkFailsIfTextMatches()
@@ -166,9 +166,9 @@ public function testDontSeeLinkFailsIfTextMatches()
166166
public function testDontSeeLinkFailsIfTextAndUrlMatches()
167167
{
168168
$this->expectException('PHPUnit\Framework\AssertionFailedError');
169-
$this->expectExceptionMessage("Link containing text 'Next' and URL 'http://codeception.com/' was found in page /external_url");
169+
$this->expectExceptionMessage("Link containing text 'Next' and URL 'https://codeception.com/' was found in page /external_url");
170170
$this->module->amOnPage('/external_url');
171-
$this->module->dontSeeLink('Next', 'http://codeception.com/');
171+
$this->module->dontSeeLink('Next', 'https://codeception.com/');
172172
}
173173

174174
public function testSeeLinkMatchesRelativeLink()

0 commit comments

Comments
 (0)