N°8781 - Improve twig base controller render error report

Author: eespie

dictionaries/en.dictionary.itop.ui.php

@@ -506,6 +506,7 @@
 	'UI:Error:MaintenanceMode'                            => 'Application is currently in maintenance',
 	'UI:Error:MaintenanceTitle'                           => 'Maintenance',
 	'UI:Error:InvalidToken'                               => 'Error: the requested operation has already been performed (CSRF token not found)',
+	'UI:Error:FormController'                             => 'Internal error in form controller',
 
 	'UI:Error:SMTP:UnknownVendor' => 'OAuth SMTP provider %1$s does not exist  (email_transport_smtp.oauth.provider)',
 

dictionaries/fr.dictionary.itop.ui.php

@@ -500,6 +500,7 @@
 	'UI:Error:MaintenanceMode' => 'L\'application est en maintenance',
 	'UI:Error:MaintenanceTitle' => 'Maintenance',
 	'UI:Error:InvalidToken' => 'Erreur: l\'opération a déjà été effectuée (CSRF token not found)',
+	'UI:Error:FormController' => 'Erreur interne',
 	'UI:Error:SMTP:UnknownVendor' => 'Le provider SMTP OAuth 2.0 %1$s n\'existe pas',
 	'UI:GroupBy:Count' => 'Nombre',
 	'UI:GroupBy:Count+' => 'Nombre d\'éléments',

sources/Application/TwigBase/Controller/Controller.php

@@ -776,6 +776,7 @@ private function RenderTemplate($aParams, $sName, $sTemplateFileExtension)
 		}
 		catch (SyntaxError $e) {
 			IssueLog::Error($e->getMessage().' - file: '.$e->getFile().'('.$e->getLine().')');
+			return $this->m_oTwig->render('application/forms/itop_error.html.twig', ['sControllerError' => $e->getMessage()]);
 		}
 		catch (Error $e) {
 			if (strpos($e->getMessage(), 'Unable to find template') === false)
@@ -825,6 +826,7 @@ private function CreatePage($sPageType)
 		}
 		$this->m_oTwig->addGlobal('UIBlockParent', [$this->m_oPage]);
 		$this->m_oTwig->addGlobal('oPage', $this->m_oPage);
+		$this->m_oTwig->addGlobal('debug', utils::IsDevelopmentEnvironment());
 	}
 
 	/**

templates/application/forms/itop_error.html.twig

@@ -0,0 +1,17 @@
+{# @copyright   Copyright (C) 2010-2025 Combodo SARL #}
+{# @license     http://opensource.org/licenses/AGPL-3.0 #}
+
+{% if debug %}
+    {% if sControllerError %}
+        {% UIContentBlock ForCode { sCode:'' } %}
+            {{ dump(sControllerError) }}
+        {% EndUIContentBlock %}
+    {% endif %}
+    {% UIContentBlock ForCode { sCode:'' } %}
+        {{ dump(_context) }}
+    {% EndUIContentBlock %}
+{% else %}
+    {% if sControllerError and not debug %}
+        {% UIAlert ForDanger { sTitle:'UI:Error:FormController'|dict_s, sContent:sControllerError } %}{% EndUIAlert %}
+    {% endif %}
+{% endif %}