Skip to content

Commit 0626bd0

Browse files
committed
fix: gate real uv-compile tests behind TEST_TORCH_BACKEND, improve README precedence docs
1 parent 7abdbbf commit 0626bd0

File tree

2 files changed

+19
-11
lines changed

2 files changed

+19
-11
lines changed

README.md

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,14 +70,17 @@ will simply update the comfy.yaml file to reflect the local setup
7070

7171
#### Python environment handling
7272

73-
When you run `comfy install`, comfy-cli decides where to install ComfyUI
74-
dependencies based on how comfy-cli itself was installed:
75-
76-
- **`pip install comfy-cli`** (global / system Python): dependencies are installed directly into
77-
the same Python environment. This is the typical setup inside Docker containers.
78-
- **`pipx install comfy-cli`** or **`uv tool install comfy-cli`** (isolated tool environment): a `.venv` is created
79-
inside the ComfyUI workspace and dependencies go there. Use `comfy launch` to start ComfyUI with the correct Python.
80-
- If a **virtualenv** or **conda** environment is already active (`VIRTUAL_ENV` / `CONDA_PREFIX`), that environment is used as-is.
73+
When you run `comfy install`, comfy-cli picks a Python environment for ComfyUI
74+
dependencies using the following precedence:
75+
76+
1. An **active virtualenv or conda** environment (`VIRTUAL_ENV` / `CONDA_PREFIX`) is used as-is.
77+
2. An **existing `.venv` or `venv`** directory inside the workspace is reused.
78+
3. Otherwise the choice depends on how comfy-cli was installed:
79+
- **`pip install comfy-cli`** (global / system Python): dependencies go
80+
directly into the same Python environment. This is the typical Docker setup.
81+
- **`pipx install comfy-cli`** or **`uv tool install comfy-cli`** (isolated
82+
tool environment): a `.venv` is created inside the ComfyUI workspace.
83+
Use `comfy launch` to start ComfyUI with the correct Python.
8184

8285
### Specifying execution path
8386

tests/comfy_cli/test_global_python_install.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,15 @@ def test_non_fast_deps_uses_global_python(self, tmp_path):
117117
MockCompiler.assert_not_called()
118118

119119

120+
@pytest.mark.skipif(
121+
os.environ.get("TEST_TORCH_BACKEND") != "true",
122+
reason="Set TEST_TORCH_BACKEND=true to run integration tests that call uv pip compile",
123+
)
120124
class TestDependencyCompilerGlobalPython:
121-
"""Run the real DependencyCompiler compile step (no mocks) using the
122-
current Python as if it were a global install. Verifies the compiled
123-
output contains expected packages and correct index URLs."""
125+
"""Integration tests: run the real DependencyCompiler compile step (no
126+
mocks, requires network) using the current Python as if it were a global
127+
install. Verifies the compiled output contains expected packages and
128+
correct index URLs."""
124129

125130
@pytest.fixture()
126131
def workspace(self, tmp_path):

0 commit comments

Comments
 (0)