Switch to using IPD ionization states for unbound evaluation

include/picongpu/particles/atomicPhysics/DeltaEnergyTransition.hpp

@@ -78,7 +78,10 @@ namespace picongpu::particles::atomicPhysics
     public:
         /** ionizationEnergy from lowerState- to upperState- chargeState
          *
+         * @param lowerStateChargeState
+         * @param upperStateChargeState
          * @param ionizationPotentialDepression, in eV
+         * @param chargeStateDataBox
          *
          * @return unit: eV
          */

include/picongpu/particles/atomicPhysics/ionizationPotentialDepression/kernel/ApplyIPDIonization.kernel

@@ -31,8 +31,10 @@
 #pragma once
 
 #include "picongpu/defines.hpp"
+#include "picongpu/particles/atomicPhysics/DeltaEnergyTransition.hpp"
 #include "picongpu/particles/atomicPhysics/SetAtomicState.hpp"
 #include "picongpu/particles/atomicPhysics/enums/ProcessClass.hpp"
+#include "picongpu/particles/atomicPhysics/enums/ProcessClassGroup.hpp"
 #include "picongpu/particles/atomicPhysics/ionizationPotentialDepression/BarrierSupressionIonization.hpp"
 #include "picongpu/particles/atomicPhysics/spawnFromSourceSpeciesModules/CacheEFieldForSuperCell.hpp"
 #include "picongpu/particles/atomicPhysics/spawnFromSourceSpeciesModules/InitAsCoMoving.hpp"
@@ -173,10 +175,6 @@ namespace picongpu::particles::atomicPhysics::ionizationPotentialDepression::ker
             uint8_t const currentChargeState
                 = T_AtomicStateDataBox::ConfigNumber::getChargeState(currentAtomicStateConfigNumber);
 
-            // eV
-            float_X const ionizationEnergy = chargeStateBox.ionizationEnergy(currentChargeState)
-                                             - atomicStateBox.energy(currentAtomicStateClctIdx);
-
             // eV
             float_X ipd = T_IPDModel::ipd(kernelState.superCellConstantIPDInput, currentChargeState);
 
@@ -198,8 +196,20 @@ namespace picongpu::particles::atomicPhysics::ionizationPotentialDepression::ker
                 ipd += BarrierSupressionIonization::getIPD(screenedCharge, eFieldNormAU);
             }
 
+            auto const ipdIonizationStateConfigNumber = atomicStateBox.configNumber(ipdIonizationStateClctIdx);
+            uint8_t const ipdIonizationStateChargeState
+                = T_AtomicStateDataBox::ConfigNumber::getChargeState(ipdIonizationStateConfigNumber);
 
-            bool const stateIsUnbound = ((ionizationEnergy - ipd) <= 0._X);
+            ///@details need to do by hand since IPD-Ionization does not always follow a defined transition
+            // eV
+            float_X const ionizationEnergyToIPDIonizationState
+                = DeltaEnergyTransition::template ionizationEnergy<
+                      s_enums::ProcessClassGroup::boundFreeBased,
+                      float_X>(currentChargeState, ipdIonizationStateChargeState, ipd, chargeStateBox)
+                  + atomicStateBox.energy(ipdIonizationStateClctIdx)
+                  - atomicStateBox.energy(currentAtomicStateClctIdx);
+
+            bool const stateIsUnbound = (ionizationEnergyToIPDIonizationState <= 0._X);
 
             /** @details states that are unbound without an IPD contribution should have option to relax via
              *  auto-ionization, electronic collisional ionization or deexcitation channels in the regular rate solver

include/picongpu/particles/atomicPhysics/rateCalculation/BoundBoundTransitionRates.hpp

@@ -219,7 +219,7 @@ namespace picongpu::particles::atomicPhysics::rateCalculation
             // check whether electron has enough kinetic energy
             if constexpr(T_excitation)
             {
-                // transition physical impossible, insufficient electron energy
+                // transition physically impossible, insufficient electron energy
                 if(energyDifference > energyElectron)
                 {
                     return 0._X;