Add crypto primitives feature to clippy checks for concordium-std.

Author: abizjak

.github/workflows/linter.yml

@@ -96,6 +96,44 @@ jobs:
           command: clippy
           args: --manifest-path ${{ matrix.lib-crates }} --target=${{ matrix.target }} --features=${{ matrix.features }} -- -D warnings
 
+  clippy-crypto-primitives:
+    name: Clippy concordium-std with crypto-primitives
+    runs-on: ubuntu-latest
+    needs: rustfmt
+    strategy:
+      matrix:
+        target:
+          - wasm32-unknown-unknown
+          - x86_64-unknown-linux-gnu
+
+        lib-crates:
+          - concordium-std/Cargo.toml
+
+        features:
+          - crypto-primitives
+
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@v2
+        with:
+          submodules: true
+
+      - name: Install toolchain with clippy available
+        uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: 1.53
+          target: ${{ matrix.target }}
+          override: true
+          components: clippy
+
+      - name: Run cargo clippy
+        uses: actions-rs/cargo@v1
+        with:
+          command: clippy
+          args: --manifest-path ${{ matrix.lib-crates }} --target=${{ matrix.target }} --features=${{ matrix.features }} -- -D warnings
+
+
   clippy-wasm32-only:
     name: Clippy Wasm32
     runs-on: ubuntu-latest

concordium-std/src/test_infrastructure.rs

@@ -841,9 +841,9 @@ impl HasCryptoPrimitives for TestCryptoPrimitives {
             let public_key = ed25519_zebra::VerificationKey::try_from(&public_key.0[..]);
             match (signature, public_key) {
                 (Ok(ref signature), Ok(public_key)) => {
-                    return public_key.verify(signature, message).is_ok()
+                    public_key.verify(signature, message).is_ok()
                 }
-                _ => return false,
+                _ => false,
             }
         }
         #[cfg(not(feature = "crypto-primitives"))]
@@ -870,9 +870,9 @@ impl HasCryptoPrimitives for TestCryptoPrimitives {
             match (signature, public_key, message_hash) {
                 (Ok(ref signature), Ok(public_key), Ok(message_hash)) => {
                     let verifier = secp256k1::Secp256k1::verification_only();
-                    return verifier.verify_ecdsa(&message_hash, &signature, &public_key).is_ok();
+                    verifier.verify_ecdsa(&message_hash, &signature, &public_key).is_ok()
                 }
-                _ => return false,
+                _ => false,
             }
         }
         #[cfg(not(feature = "crypto-primitives"))]