[CSL 235] Remove action from browse url query params (#62)

* Add section to browse result load, remove action

* Pass section to body

Author: crgee1

library/src/main/java/io/constructor/core/Constants.kt

@@ -48,7 +48,6 @@ class Constants {
         const val SEARCH_SUGGESTIONS = "Search Suggestions"
         const val PRODUCTS = "Products"
         const val EVENT_SEARCH_RESULTS = "search-results"
-        const val EVENT_BROWSE_RESULTS = "browse-results"
         const val EVENT_INPUT_FOCUS = "focus"
     }
 }

library/src/main/java/io/constructor/core/ConstructorIo.kt

@@ -367,14 +367,15 @@ object ConstructorIo {
      * @param filterValue the value of the primary filter, i.e. "Produce"
      * @param resultCount the number of results for that filter name/value pair
      */
-    fun trackBrowseResultsLoaded(filterName: String, filterValue: String, resultCount: Int, url: String = "Not Available") {
-        var completable = trackBrowseResultsLoadedInternal(filterName, filterValue, resultCount, url)
+    fun trackBrowseResultsLoaded(filterName: String, filterValue: String, resultCount: Int, sectionName: String? = null, url: String = "Not Available") {
+        var completable = trackBrowseResultsLoadedInternal(filterName, filterValue, resultCount, sectionName, url)
         disposable.add(completable.subscribeOn(Schedulers.io()).subscribe({}, {
             t -> e("Browse Results Loaded error: ${t.message}")
         }))
     }
-    internal fun trackBrowseResultsLoadedInternal(filterName: String, filterValue: String, resultCount: Int, url: String = "Not Available"): Completable {
+    internal fun trackBrowseResultsLoadedInternal(filterName: String, filterValue: String, resultCount: Int, sectionName: String? = null, url: String = "Not Available"): Completable {
         preferenceHelper.getSessionId(sessionIncrementHandler)
+        val section = sectionName ?: preferenceHelper.defaultItemSection
         val browseResultLoadRequestBody = BrowseResultLoadRequestBody(
                 filterName,
                 filterValue,
@@ -387,13 +388,13 @@ object ConstructorIo {
                 configMemoryHolder.userId,
                 configMemoryHolder.segments,
                 true,
-                preferenceHelper.defaultItemSection,
+                section,
                 System.currentTimeMillis()
         )
 
         return dataManager.trackBrowseResultsLoaded(
                 browseResultLoadRequestBody,
-                arrayOf(Constants.QueryConstants.ACTION to Constants.QueryValues.EVENT_BROWSE_RESULTS)
+                arrayOf(Constants.QueryConstants.SECTION to section)
         )
     }
 

library/src/test/java/io/constructor/core/ConstructorIoTrackingTest.kt

@@ -380,7 +380,7 @@ class ConstructorIoTrackingTest {
         val observer = ConstructorIo.trackBrowseResultsLoadedInternal("group_id", "Movies", 10).test()
         observer.assertComplete()
         val request = mockServer.takeRequest()
-        val path = "/v2/behavioral_action/browse_result_load?action=browse-results&key=copper-key&i=wacko-the-guid&ui=player-three&s=67&c=cioand-2.5.0&_dt="
+        val path = "/v2/behavioral_action/browse_result_load?section=Products&key=copper-key&i=wacko-the-guid&ui=player-three&s=67&c=cioand-2.5.0&_dt="
         assert(request.path.startsWith(path))
         assertTrue(request.bodySize > 215)
         assertEquals("POST", request.method)
@@ -393,7 +393,7 @@ class ConstructorIoTrackingTest {
         val observer = ConstructorIo.trackBrowseResultsLoadedInternal("group_id", "Movies", 10).test()
         observer.assertError { true }
         val request = mockServer.takeRequest()
-        val path = "/v2/behavioral_action/browse_result_load?action=browse-results&key=copper-key&i=wacko-the-guid&ui=player-three&s=67&c=cioand-2.5.0&_dt="
+        val path = "/v2/behavioral_action/browse_result_load?section=Products&key=copper-key&i=wacko-the-guid&ui=player-three&s=67&c=cioand-2.5.0&_dt="
         assert(request.path.startsWith(path))
         assertTrue(request.bodySize > 220)
         assertEquals("POST", request.method)