Skip to content

Commit 070b97c

Browse files
evanyan13Evan Yan
andauthored
[NOCI] Bugfix: Rendering More than Expected Number of Items (#231)
* Update key assignment to section item * Update key for custom section --------- Co-authored-by: Evan Yan <[email protected]>
1 parent 22c61ba commit 070b97c

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/components/Autocomplete/SectionItem/SectionItem.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import SearchSuggestionItem from './SearchSuggestionItem';
99
export interface SectionItemProps {
1010
item: Item;
1111
children?: ReactNode;
12-
key?: string;
1312
displaySearchTermHighlights?: boolean;
1413
}
1514

src/components/Autocomplete/SectionItemsList/SectionItemsList.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ export type RenderSectionItemsList = (renderResultsArguments: {
1414
type SectionItemsListProps = {
1515
section: Section;
1616
children?: RenderSectionItemsList;
17-
key?: string;
1817
};
1918

2019
// eslint-disable-next-line func-names
@@ -70,14 +69,14 @@ const DefaultRenderSectionItemsList: RenderSectionItemsList = function ({ sectio
7069
renderItem={section.renderItem}
7170
item={item}
7271
query={query}
73-
key={item.id}
72+
key={item?.data?.variation_id || item?.id}
7473
/>
7574
);
7675
}
7776
return (
7877
<SectionItem
7978
item={item}
80-
key={item?.id}
79+
key={item?.data?.variation_id || item?.id}
8180
displaySearchTermHighlights={section.displaySearchTermHighlights}
8281
/>
8382
);

0 commit comments

Comments
 (0)