Skip to content

Commit 7697633

Browse files
TarekAlQaddyTarek Ahmed
andauthored
Bump Axios, Playwright and Vite (#259)
* bump packages * Include playwright as a dev dependency * Remove playwright as a dependancy, install playwright in the workflow * Remove unneeded eslint rule --------- Co-authored-by: Tarek Ahmed <[email protected]>
1 parent fdbfc69 commit 7697633

File tree

4 files changed

+65
-51
lines changed

4 files changed

+65
-51
lines changed

.eslintrc.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,12 @@
6565
"jest": true,
6666
"jest/globals": true
6767
},
68-
"plugins": ["jest", "no-snapshot-testing", "testing-library"],
68+
"plugins": ["jest", "testing-library"],
6969
"extends": ["plugin:jest/recommended", "plugin:testing-library/react"],
7070
"rules": {
7171
// https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/no-node-access.md
7272
"testing-library/no-node-access": ["error", { "allowContainerFirstChild": true }],
7373
// https://github.com/VicJer/eslint-plugin-no-snapshot-testing
74-
"no-snapshot-testing/no-snapshot-testing": "error",
7574
"import/no-extraneous-dependencies": [
7675
"error",
7776
{ "devDependencies": true, "peerDependencies": true }

.github/workflows/test-storybook.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,7 @@ jobs:
2020
node-version: '18.13.0'
2121
- name: Install dependencies
2222
run: npm ci
23+
- name: Install Playwright browsers
24+
run: npx playwright install
2325
- name: Run Tests
2426
run: npm run test-storybook:ci

package-lock.json

Lines changed: 62 additions & 48 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@
9494
"eslint-plugin-import": "^2.26.0",
9595
"eslint-plugin-jest": "^27.9.0",
9696
"eslint-plugin-jsx-a11y": "^6.7.1",
97-
"eslint-plugin-no-snapshot-testing": "^1.0.61",
9897
"eslint-plugin-prettier": "^4.2.1",
9998
"eslint-plugin-react": "^7.31.11",
10099
"eslint-plugin-react-hooks": "^4.6.0",

0 commit comments

Comments
 (0)