Renaming the ID kwargs for different command types in tanjun.Client, etc.
#361
GoogolGenius
started this conversation in
Ideas
Replies: 2 comments
-
|
hmmmmmmmmmmmmmmmmmmmm |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Yeah i'll add those aliases |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
https://github.com/FasterSpeeding/Tanjun/blob/master/tanjun/clients.py#L552-L554
I personally feel like some of these kwargs here should be renamed to be more verbose and specific as especially
message_idsanduser_idsseem very confusing. They may refer tohikari.Userids orhikari.Messageids, etc if not looking at the type hint.Perhaps
message_cmd_idsormessage_command_idswould be a better naming scheme. Forcommand_idsit could be deprecated toslash_cmd_idsorslash_command_idsor whatever you feel would work best, just specifying that it is for slash commands.As mentioned previously, it would be ideal in my opinion to rename and deprecate these kwargs and potentially other namings like this that apply to the library.
Beta Was this translation helpful? Give feedback.
All reactions