Skip to content

Conversation

@sabrina0822
Copy link
Contributor

Resolves: (#ID-of-the-issue)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

Copy link
Contributor

@malajvan malajvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me !

Copy link
Contributor

@softcat477 softcat477 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also delete https://github.com/DDMAL/Rodan/blob/develop/runLog.txt and https://github.com/DDMAL/Rodan/blob/develop/starter.sh since they're added in the same commit as run_containers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants