Skip to content

Conversation

@jackyyzhang03
Copy link
Contributor

@jackyyzhang03 jackyyzhang03 commented Aug 11, 2023

Resolves: (#1057)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

(Describe the changes you've made and the purpose of this PR)

  • Remove SERVER_HOST environment variable in staging.sample and production.sample which is already provided in staging.yml and production.yml
  • Move SERVER_HOST environment variable fromlocal.env to docker-compose.yml and arm-compose.yml to be consistent with staging and production

malajvan
malajvan previously approved these changes Aug 21, 2023
@malajvan malajvan self-requested a review August 21, 2023 13:39
@malajvan malajvan dismissed their stale review August 21, 2023 13:41

need to cross check with katie's new branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SERVER_HOST environment variable is redundant in staging.sample and production.sample

3 participants